[Bug 1416455] Review Request: python-easywatch - super simple directory monitoring

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1416455



--- Comment #1 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> ---
Hello Fabio,

The summary for the python3 package is the summary of another package. You
could use the summary macro to avoid that.

It would be nice ask upstream to add tags to avoid getting sources from the
commits (of course this is not a blocker).

rpmlint has this warning, would you fix it (not a blocker)?
python2-easywatch.noarch: W: summary-not-capitalized C super simple directory
monitoring


This is the docstring for easywatch/easywatch.py
"""
Simple static page generator.
Uses jinja2 to compile templates.
Templates should live inside `./templates` and will be compiled in '.'.
"""

It would be nice to patch it and send it upstream.

python3 package fails importing watchdog function (see __init__.py), here is
the  error message:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.6/site-packages/easywatch/__init__.py", line 1, in
<module>
    from easywatch import watch
ImportError: cannot import name 'watch'

This happens because __init__.py has a relative import (see
https://www.python.org/dev/peps/pep-0404/). I'd say the package is not python3
compatible yet (probably just because of that import)


Finally, there are Requires: missing, as you can see below:

in easywatch/easywatch.py we have:
from watchdog.observers import Observer
from watchdog.events import FileSystemEventHandler

importing the python2 package results in:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'watchdog'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]