https://bugzilla.redhat.com/show_bug.cgi?id=1327635 Javier Peña <jpena@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Assignee|dradez@xxxxxxxxxx |jpena@xxxxxxxxxx Flags| |rdo-review+ --- Comment #17 from Javier Peña <jpena@xxxxxxxxxx> --- - The SRPM differences with the spec are expected, since it's generated by DLRN. Same goes for the tarball not being downloadable. The package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache", "BSD (3 clause)", "Unknown or generated", "*No copyright* Apache (v2.0)". 388 files have unknown license. Detailed output of licensecheck in /tmp/congress /review-openstack-congress/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/openstack-dashboard, /usr/share /openstack-dashboard/openstack_dashboard/local/enabled, /etc /openstack-dashboard/enabled, /usr/share/openstack- dashboard/openstack_dashboard, /usr/share/openstack- dashboard/openstack_dashboard/local, /etc/openstack-dashboard [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/openstack- dashboard/openstack_dashboard/local/enabled, /usr/share/openstack- dashboard/openstack_dashboard/local, /etc/openstack-dashboard/enabled, /usr/share/openstack-dashboard/openstack_dashboard, /etc/logrotate.d, /usr/share/openstack-dashboard, /etc/openstack-dashboard [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://tarballs.openstack.org/congress/congress-5.0.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python- congress , openstack-congress-common , python-congress-tests , python- congress-dashboard , python-congress-doc , python-antlr3runtime [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: openstack-congress-5.0.0-0.20170207183957.54926c4.el7.centos.noarch.rpm python-congress-5.0.0-0.20170207183957.54926c4.el7.centos.noarch.rpm openstack-congress-common-5.0.0-0.20170207183957.54926c4.el7.centos.noarch.rpm python-congress-tests-5.0.0-0.20170207183957.54926c4.el7.centos.noarch.rpm python-congress-dashboard-5.0.0-0.20170207183957.54926c4.el7.centos.noarch.rpm python-congress-doc-5.0.0-0.20170207183957.54926c4.el7.centos.noarch.rpm python-antlr3runtime-5.0.0-0.20170207183957.54926c4.el7.centos.noarch.rpm openstack-congress-5.0.0-0.20170207183957.54926c4.el7.centos.src.rpm openstack-congress.noarch: E: no-changelogname-tag openstack-congress.noarch: W: no-documentation openstack-congress.noarch: W: no-manual-page-for-binary congress-server openstack-congress.noarch: W: no-manual-page-for-binary congress-db-manage python-congress.noarch: E: no-changelogname-tag python-congress.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/congress/datasources/neutronv2_driver.py /usr/bin/env python python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/datasources/neutronv2_driver.py 644 /usr/bin/env python python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/server/congress_server.py 644 /usr/bin/python python-congress.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/congress/datasources/cloudfoundryv2_driver.py /usr/bin/env python python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/datasources/cloudfoundryv2_driver.py 644 /usr/bin/env python python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/datalog/builtin.py 644 /usr/bin/python openstack-congress-common.noarch: W: summary-not-capitalized C congress common files openstack-congress-common.noarch: E: no-changelogname-tag openstack-congress-common.noarch: W: non-standard-gid /etc/congress/congress.conf congress openstack-congress-common.noarch: E: non-readable /etc/congress/congress.conf 640 openstack-congress-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/openstack-congress openstack-congress-common.noarch: W: non-standard-uid /var/log/congress congress openstack-congress-common.noarch: E: non-standard-dir-perm /var/log/congress 750 python-congress-tests.noarch: E: no-changelogname-tag python-congress-tests.noarch: W: no-documentation python-congress-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/tests/datalog/test_builtin.py 644 /usr/bin/python python-congress-dashboard.noarch: E: no-changelogname-tag python-congress-dashboard.noarch: W: no-documentation python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_70_datasources.py python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_60_policies.pyc python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_70_datasources.pyo python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_60_policies.py python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_50_policy.py python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_60_policies.pyo python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_70_datasources.pyc python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_50_policy.pyc python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_50_policy.pyo python-congress-doc.noarch: E: no-changelogname-tag python-congress-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-congress-doc-5.0.0/html/objects.inv python-congress-doc.noarch: W: file-not-utf8 /usr/share/doc/python-congress-doc-5.0.0/html/objects.inv python-antlr3runtime.noarch: W: spelling-error Summary(en_US) Antlr -> Antler python-antlr3runtime.noarch: W: spelling-error %description -l en_US Antlr -> Antler python-antlr3runtime.noarch: E: no-changelogname-tag python-antlr3runtime.noarch: W: no-documentation openstack-congress.src: E: no-changelogname-tag openstack-congress.src:222: W: macro-in-comment %{buildroot} openstack-congress.src:222: W: macro-in-comment %{pypi_name} openstack-congress.src:222: W: macro-in-comment %{buildroot} openstack-congress.src:222: W: macro-in-comment %{_sysconfdir} openstack-congress.src:222: W: macro-in-comment %{pypi_name} openstack-congress.src:223: W: macro-in-comment %{buildroot} openstack-congress.src:223: W: macro-in-comment %{buildroot} openstack-congress.src:223: W: macro-in-comment %{_sysconfdir} openstack-congress.src:249: W: macro-in-comment %check openstack-congress.src:250: W: macro-in-comment %{__python2} openstack-congress.src:251: W: macro-in-comment %{with openstack-congress.src:253: W: macro-in-comment %endif openstack-congress.src: W: invalid-url Source0: congress-5.0.0.0rc1-0.20170207183957.54926c4.tar.gz 8 packages and 0 specfiles checked; 18 errors, 35 warnings. Rpmlint (installed packages) ---------------------------- python-congress-dashboard.noarch: E: no-changelogname-tag python-congress-dashboard.noarch: W: no-documentation python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_60_policies.pyo python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_60_policies.pyc python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_70_datasources.py python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_60_policies.py python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_50_policy.py python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_50_policy.pyc python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_50_policy.pyo python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_70_datasources.pyo python-congress-dashboard.noarch: W: non-conffile-in-etc /etc/openstack-dashboard/enabled/_70_datasources.pyc openstack-congress.noarch: E: no-changelogname-tag openstack-congress.noarch: W: only-non-binary-in-usr-lib openstack-congress.noarch: W: no-documentation openstack-congress.noarch: W: no-manual-page-for-binary congress-db-manage openstack-congress.noarch: W: no-manual-page-for-binary congress-server python-congress-tests.noarch: E: no-changelogname-tag python-congress-tests.noarch: W: no-documentation python-congress-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/tests/datalog/test_builtin.py 0644L /usr/bin/python openstack-congress-common.noarch: W: summary-not-capitalized C congress common files openstack-congress-common.noarch: E: no-changelogname-tag openstack-congress-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/openstack-congress openstack-congress-common.noarch: W: non-standard-uid /var/log/congress congress openstack-congress-common.noarch: E: non-standard-dir-perm /var/log/congress 0750L openstack-congress-common.noarch: W: non-standard-gid /etc/congress/congress.conf congress openstack-congress-common.noarch: E: non-readable /etc/congress/congress.conf 0640L python-congress-doc.noarch: E: no-changelogname-tag python-antlr3runtime.noarch: E: no-changelogname-tag python-antlr3runtime.noarch: W: no-documentation python-congress.noarch: E: no-changelogname-tag python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/datasources/neutronv2_driver.py 0644L /usr/bin/env python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/datasources/cloudfoundryv2_driver.py 0644L /usr/bin/env python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/datalog/builtin.py 0644L /usr/bin/python python-congress.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/congress/server/congress_server.py 0644L /usr/bin/python 7 packages and 0 specfiles checked; 15 errors, 19 warnings. Diff spec file in url and in SRPM --------------------------------- --- /tmp/congress/openstack-congress.spec 2017-02-07 23:24:02.774975681 +0100 +++ /tmp/congress/review-openstack-congress/srpm-unpacked/openstack-congress.spec 2017-02-07 19:39:57.000000000 +0100 @@ -1,2 +1,4 @@ +%global dlrn 1 +%define upstream_version 5.0.0.0rc1 %global pypi_name congress @@ -4,11 +6,11 @@ Name: openstack-%{pypi_name} -Version: 5.0.0 -Release: 0.20170207183957.54926c4 +Version: 5.0.0 +Release: 0.20170207183957.54926c4%{?dist} Summary: OpenStack Congress Service License: ASL 2.0 URL: https://launchpad.net/%{pypi_name} -Source0: http://tarballs.openstack.org/%{pypi_name}/%{pypi_name}-%{version}.tar.gz +Source0: congress-5.0.0.0rc1-0.20170207183957.54926c4.tar.gz Source1: openstack-congress-server.service Source2: congress.logrotate @@ -316,4 +318,2 @@ %changelog -* Thu Jan 12 2017 Dan Radez <dradez@xxxxxxxxxx> - 5.0.0.0b2-1 -- Initial Packaging Requires -------- python-congress-dashboard (rpmlib, GLIBC filtered): openstack-dashboard python(abi) openstack-congress (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 openstack-congress-common python-antlr3runtime python-eventlet python-heat-translator python-heatclient python-neutronclient python-oslo-db python-oslo-log python-oslo-messaging python-oslo-policy python-oslo-service python-oslo-sphinx python-paramiko python-routes python-tosca-parser python-webob shadow-utils systemd python-congress-tests (rpmlib, GLIBC filtered): python(abi) python-cliff python-congress python-coverage python-fixtures python-hacking python-mock python-ordereddict python-os-testr python-oslotest python-subunit python-tackerclient python-tempest python-tenacity python-testrepository python-testtools python-webtest openstack-congress-common (rpmlib, GLIBC filtered): /bin/sh config(openstack-congress-common) python-congress python-congress-doc (rpmlib, GLIBC filtered): python-antlr3runtime (rpmlib, GLIBC filtered): python(abi) python-congress (rpmlib, GLIBC filtered): python(abi) python-PuLP python-alembic python-babel python-ceilometerclient python-cinderclient python-dateutil python-eventlet python-glanceclient python-heatclient python-ironicclient python-keystoneauth1 python-keystoneclient python-keystonemiddleware python-muranoclient python-neutronclient python-novaclient python-oslo-concurrency python-oslo-config python-oslo-context python-oslo-db python-oslo-log python-oslo-messaging python-oslo-middleware python-oslo-policy python-oslo-serialization python-oslo-service python-oslo-utils python-oslo-vmware python-paste python-paste-deploy python-pbr python-routes python-six python-swiftclient python-webob Provides -------- python-congress-dashboard: python-congress-dashboard openstack-congress: openstack-congress python-congress-tests: python-congress-tests openstack-congress-common: config(openstack-congress-common) openstack-congress-common python-congress-doc: python-congress-doc python-antlr3runtime: python-antlr3runtime python-congress: python-congress Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -n openstack-congress -m dlrn Buildroot used: dlrn-centos7-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx