https://bugzilla.redhat.com/show_bug.cgi?id=1415331 --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Thank you for the review. > - Please try to send your patches to upstream: manpage, install and start > script. > https://fedoraproject.org/wiki/Packaging: > Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment The man page is from debian. I submitted a bug report asking them to upstream it. Upstream provides a much more involved script which tries to detect python3 and pypy, which is not suitable for Fedora, since we want to use %__python3 unconditionally. The script create in the spec file is one line and it's not suitable for upstream, for example `-O` is only useful for packaged applications where the user does not have write permission to the installation directory and byte-compilation is done externally. > - Why does upstream not provide a build/install environment? A proper build > script can avoid confusion about right build flags. Maybe we can suggest > setuptools. > https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling This is what upstream recommends in the README. The installation is trivial, so I don't think this is much of an issue. > - The sitelib folder should be in a separate subpackage python3-enjarify > with support for the virtual provides of python-enjarify. > https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro I renamed the main package to enjarify. This actually matches what upstream uses for the project name better, and added the python3-subpackage and %python_provide. > - Manpage is special documentation without the need to be marked with %doc. > https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages Fixed. > - Please use also install -p for the manpage to preserve original timestamp. > https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps Fixed. Spec URL: http://in.waw.pl/~zbyszek/fedora/enjarify.spec SRPM URL: http://in.waw.pl/~zbyszek/fedora/enjarify-1.0.3-1.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx