https://bugzilla.redhat.com/show_bug.cgi?id=1418310 --- Comment #11 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> --- (In reply to Andrew Bauer from comment #10) > rpmlint reports some issues: > > perl-SOAP-WSDL.noarch: W: no-documentation > perl-SOAP-WSDL.noarch: E: zero-length > /usr/share/perl5/vendor_perl/SOAP/WSDL/Generator/Template/XSD/complexType/ > POD/content_model.tt > perl-SOAP-WSDL.noarch: W: no-manual-page-for-binary wsdl2perl.pl > perl-SOAP-WSDL-Apache.noarch: W: no-documentation > perl-SOAP-WSDL-doc.noarch: W: hidden-file-or-dir > /usr/share/doc/perl-SOAP-WSDL-doc/example/java/cxf/.classpath > perl-SOAP-WSDL-doc.noarch: W: hidden-file-or-dir > /usr/share/doc/perl-SOAP-WSDL-doc/example/java/cxf/.settings > perl-SOAP-WSDL-doc.noarch: W: hidden-file-or-dir > /usr/share/doc/perl-SOAP-WSDL-doc/example/java/cxf/.settings > 4 packages and 0 specfiles checked; 1 errors, 6 warnings. > > These look fixable. > > hidden-file-or-dir > In %prep, compress the example folder into a .gz and then add that single > file to %doc. > If you need an example, look at the sed package srpm. I don't see anything wrong having a file which I can directly load into Eclipse without any extra steps. FYI in my F25 I have 62 such a files: # find /usr -name '\.*' | wc -l 62 > > no-documentation > Even though we have a dedicated "doc" subpackage, rpmlint still wants us to > have a %doc in the other subpackages. > From looking at a few other example specfiles, lets include the README and > license in each subpackage. License is already in all subpackages, I've just moved: Changes, HACKING, README and TODO to the main package. > > no-manual-page-for-binary > The man page for wsdl2perl gets auto-magically created from the pod text > during the build: > Installing > /builddir/build/BUILDROOT/perl-SOAP-WSDL-3.003-2.fc26.noarch/usr/share/man/ > man1/wsdl2perl.pl.1 > > So we just need to pick up this file in %files e.g. > %{_mandir}/man1/wsdl2perl.pl.1 > It was already there, but in the -doc subpackage which seemed to be misleading for rpmlint, thus I've moved all (two) manpages to main package and rename -doc to -examples as it no longer contains documentation. > zero-length > I admit this is a bit picky, but let's insert the string "# No documentation To me it's purely false positive, in my F25 system I see hundreds similar cases, mostly: __init__.py # find /usr -size 0 | wc -l 150 > generated for content_model yet" into content_model.tt. > > This appears to be what has been done to a couple other files in this > package: > https://github.com/scrottie/SOAP-WSDL/tree/master/lib/SOAP/WSDL/Generator/ > Template/XSD/complexType/POD/simpleContent Changelog: - Move man pages, Changes, HACKING, README and TODO to main package, - Rename subpackage -doc to -examples Apart from above cosmetic changes, I would prefer not to change other things unless someone has strong argument to do so. Updated spec & srpm: Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/perl-SOAP-WSDL.spec SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/perl-SOAP-WSDL-3.003-4.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx