https://bugzilla.redhat.com/show_bug.cgi?id=1385856 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #6 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- I don't get this insistence on substituting all occurrences of the name with %name. For example, if I want to open the URL field in browser, c&p is not enough, I need to manually replace %name. IMHO, such changes are a cargo-cult. Just saying. Suggestions: make %{?_smp_mflags} → %make_build make install DESTDIR=%{buildroot} → %make_install + package name is OK + license is acceptable (LGPv2+) + builds and installs OK + provides/requires/buildrequires look correct + scriptlets are sane + fedora-review doesn't point out any issues Package is APPROVED. rpmlint: log4shib.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog4shib.so.1.0.9 pthread_key_create log4shib.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog4shib.so.1.0.9 pthread_getspecific log4shib.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog4shib.so.1.0.9 pthread_key_delete log4shib.x86_64: W: undefined-non-weak-symbol /usr/lib64/liblog4shib.so.1.0.9 pthread_setspecific I think that's related to the recent glibc changes, not a problem with this package. log4shib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblog4shib.so.1.0.9 /lib64/libnsl.so.1 log4shib.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liblog4shib.so.1.0.9 /lib64/libm.so.6 Both of those libraries are provided by glibc, so this extra dep is harmless. log4shib.x86_64: W: file-not-utf8 /usr/share/doc/log4shib/THANKS log4shib.x86_64: E: incorrect-fsf-address /usr/share/licenses/log4shib/COPYING Like Vasiliy said, you might want to fix those, or maybe notify upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx