[Bug 1419043] Review Request: perl-Sub-Exporter-Lexical - Export lexically-available subs with Sub:: Exporter

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1419043



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --provides perl-Sub-Exporter-Lexical-0.092292-1.fc26.noarch.rpm |
sort | uniq -c
      1 perl(Sub::Exporter::Lexical) = 0.092292
      1 perl-Sub-Exporter-Lexical = 0.092292-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Sub-Exporter-Lexical*
 perl-Sub-Exporter-Lexical.noarch: W: spelling-error Summary(en_US) lexically
-> lexical, exotically, allergically
 perl-Sub-Exporter-Lexical.src: W: spelling-error Summary(en_US) lexically ->
lexical, exotically, allergically
 2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

BuildRequires
FIX: Please remove duplicity 'perl(strict)' in BR.
FIX: Please change the version restriction for perl(ExtUtils::MakeMaker) to
     6.76 or higher, because NO_PACKLIST option (spec file line 37) was
     added in this version.

$ rpm -qplv perl-Sub-Exporter-Lexical-0.092292-1.fc26.noarch.rpm
drwxr-xr-x    2 root    root     0 Feb  7 10:35
/usr/share/doc/perl-Sub-Exporter-Lexical
-rw-r--r--    1 root    root   290 Nov 24  2013
/usr/share/doc/perl-Sub-Exporter-Lexical/Changes
-rw-r--r--    1 root    root   332 Nov 24  2013
/usr/share/doc/perl-Sub-Exporter-Lexical/README
drwxr-xr-x    2 root    root     0 Feb  7 10:35
/usr/share/licenses/perl-Sub-Exporter-Lexical
-rw-r--r--    1 root    root 18353 Nov 24  2013
/usr/share/licenses/perl-Sub-Exporter-Lexical/LICENSE
-rw-r--r--    1 root    root  2472 Feb  7 10:35
/usr/share/man/man3/Sub::Exporter::Lexical.3pm.gz
drwxr-xr-x    2 root    root     0 Feb  7 10:35
/usr/share/perl5/vendor_perl/Sub
drwxr-xr-x    2 root    root     0 Feb  7 10:35
/usr/share/perl5/vendor_perl/Sub/Exporter
-rw-r--r--    1 root    root  4118 Nov 24  2013
/usr/share/perl5/vendor_perl/Sub/Exporter/Lexical.pm
-rw-r--r--    1 root    root   779 Nov 24  2013
/usr/share/perl5/vendor_perl/Sub/Exporter/snippet.pl

$ rpm -qp --requires perl-Sub-Exporter-Lexical-0.092292-1.fc26.noarch.rpm |
sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.12.0
      1 perl(Lexical::Sub)
      1 perl(Sub::Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are not Ok.

FIX: Do you want to distribute the file 'snippet.pl'? It was put into
     /usr/share/perl5/vendor_perl/Sub/Exporter. The dependencies for the file
     are not generated, because 'file' detects it as 'ASCII text' and rpm-build 
     does not process it by perl-generators.

$ file Sub-Exporter-Lexical-0.092292/snippet.pl
Sub-Exporter-Lexical-0.092292/snippet.pl: ASCII text

     The missing run-require dependencies for 'snippet.pl' are:
       perl(B::Hooks::EndOfScope)
       perl(Carp)
       perl(Sub::Install)
       perl(namespace::autoclean)
       perl(namespace::clean)


Please correct 'FIX' issues and provide new spec file.

Otherwise the package looks good.
Not approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]