Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdelibs3 - K Desktop Environment 3 - Libraries https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248899 kevin@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From kevin@xxxxxxxxxxxxxxxx 2007-07-20 21:14 EST ------- > * lib_loader patch doesn't apply, besides, most .la files are still required > anyway. OK. > * ui_resources.rc: I installed kdelibs-3.91... and k;delibs3 side-by-side, > and didn't see any file conflict wrt ui_resources.rc (did you?). If this is > indeed a problem, we need a fixed patch (the provide one from Than didn't > build). Maybe we get away with the conflict because it's a %config file? I'll take you word for it that it installs anyway. We need to look at the problem sooner or later, but let's not make this a blocker for importing. > MUST items remaining todo: > * rpmlint issues... I can sort that out, I'd prefer if you listed explicitly > what you require. See list of TODOs below. > * kresources.desktop: I doubt this is really a prob, it's a kde-only thing, > that probably contains keywords are something not technically valid according > to spec. Fixing this may well require patching kde. imo, not worth it. Then let's give it a pass. > * exclude dcopidl: can do OK. TODO: * remove execute permissions from /etc/profile.d/kde3.*sh * add %doc COPYING * remove dot at the end of -devel summary * exclude dcopidl* from main package * rename the specfile to the correct name As these are all minor issues, I'm going ahead and approving this, but please address them before or immediately after the import. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review