[Bug 1391444] Review Request: boost159 - The free peer-reviewed portable C++ source libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1391444



--- Comment #13 from Javier Peña <jpena@xxxxxxxxxx> ---
fedora-review has found a few issues:

- boost159-static obsoletes boost-devel-static < 1.34.1-14, but it doesn't
provide it (it provides boost159-devel-static).
- same happens to boost159-mpich2, boost159-mpich-devel,
boost159-mpich2-python. I guess we could remove all obsoletes to avoid issues
with the main boost packages.
- It has BR: python-devel, while it should be python2-devel
- It doesn't like that libraries define an rpath, I'd need more information on
this.
- Some subpackages seem to be missing an ldconfig in %postin and %postun:
boost159-openmpi, boost159-openmpi-python, boost159-graph-openmpi,
boost159-mpich, boost159-mpich-python, boost159-graph-mpich

As part of the SHOULD items:

- There should be no %clean section in the spec

The following are non-issues:

- licensecheck is finding two GPL-licensed files, but those are covered by the
special exception in the Bison license, so there is no issue there.

- Header files in -devel subpackage are in an example, so expected.

- Documentation is already in a -doc subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]