https://bugzilla.redhat.com/show_bug.cgi?id=1418006 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source archive (SHA-256: 9790b7f9b97698ea2c530436c6090c25119c6f5bd2f70d78afc49922c3f0276d) is original. Ok. Summary is Ok. TODO: I'd emphasize the module is about exceptions in tests like "Simple system for handling some exceptions in tests". Description verified from lib/Test/Abortable.pm. Ok. License verified from lib/Test/Abortable.pm, LICENSE, README. Ok. No XS code, noarch BuildArch is Ok. CPAN::Meta and CPAN::Meta::Prereqs are not helpful. Ok. Build-time dependencies are Ok. All tests pass. Ok. $ rpmlint perl-Test-Abortable.spec ../SRPMS/perl-Test-Abortable-0.002-1.fc26.src.rpm ../RPMS/noarch/perl-Test-Abortable-0.002-1.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Test-Abortable-0.002-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Feb 6 13:29 /usr/share/doc/perl-Test-Abortable -rw-r--r-- 1 root root 268 Jan 16 19:01 /usr/share/doc/perl-Test-Abortable/Changes -rw-r--r-- 1 root root 398 Jan 16 19:01 /usr/share/doc/perl-Test-Abortable/README drwxr-xr-x 2 root root 0 Feb 6 13:29 /usr/share/licenses/perl-Test-Abortable -rw-r--r-- 1 root root 18355 Jan 16 19:01 /usr/share/licenses/perl-Test-Abortable/LICENSE -rw-r--r-- 1 root root 3294 Feb 6 13:29 /usr/share/man/man3/Test::Abortable.3pm.gz drwxr-xr-x 2 root root 0 Feb 6 13:29 /usr/share/perl5/vendor_perl/Test -rw-r--r-- 1 root root 11867 Jan 16 19:01 /usr/share/perl5/vendor_perl/Test/Abortable.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Test-Abortable-0.002-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(strict) 1 perl(Sub::Exporter) 1 perl(Test2::API) >= 1.302075 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Test-Abortable-0.002-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Test::Abortable) = 0.002 1 perl-Test-Abortable = 0.002-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Test-Abortable-0.002-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17632057). Ok. Package is in line with Fedora and Perl guidelines. Please consider fixing the `TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx