https://bugzilla.redhat.com/show_bug.cgi?id=1418157 --- Comment #2 from Darryl T. Agostinelli <dagostinelli@xxxxxxxxx> --- Thank you for your review. As this is my first time, I have some questions. * After I make the revisions, shall I bump the version number in the .spec file or the release number or bump nothing? >Version: 1.0.0 >Release: 1%{dist} vs >Version: 1.0.0 >Release: 2%{dist} vs >Version: 1.0.1 >Release: 1%{dist} * Is it preferred that there be a new .spec file or shall I replace the original .spec file with my revisions from your review? * Regarding the Summary: A pure-C math library for 2D/3D graphics (matrix, vector, quaternion) It is an important detail to mention that the library has to do with matrices, vectors and quaternions so as to separate it from other graphical packages that deal with other aspects of graphics programming. How about this: C library for 2D/3D graphics (matrix, vector, quaternion) * The library can be built from source with either 32-bit or 64-bit floats. float vs double. This is expressed with a build flag: cmake . -DHYPATIA_SINGLE_PRECISION_FLOATS=ON It is hard to say precisely what a user of the library would like to use. I've defaulted it to double precision floats in the package in the assumption that its favorable over the single precision floats. In my own work, however, I prefer the single precision floats. What is your advice? * While I refer to the library as 'Hypatia', as I'm making the corrections that you suggested, I noticed that the doc and license folder for other libraries have the lib prefix. Is it more correct to cause the .spec file to label the various directories (doc, license, etc) as 'libhypatia' instead of 'hypatia'? /usr/share/licenses/libhypatia /usr/share/doc/libhypatia vs /usr/share/licenses/hypatia /usr/share/doc/hypatia -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx