https://bugzilla.redhat.com/show_bug.cgi?id=1411467 --- Comment #4 from Garrett Holmstrom <gholms@xxxxxxxxxxxxxxxxx> --- In reply to Neal Gompa from comment #3) > Some notes: > > > rm $RPM_BUILD_ROOT/%{_libdir}/bitlbee/steam.la > > Please use %{buildroot} instead of "$RPM_BUILD_ROOT" The spec file wasn't up to date with current packaging guidelines anyway, so I replaced the calls to make with %make_build and %make_install. The file is now consistent. > > %{!?_licensedir: %global license %%doc} > > This should be "%{!?_licensedir: %global license %doc}" Removed; it isn't necessary any more. > Additional notes: > > This package provides "steam.so()(64bit)" which is unhelpfully generic. > Please add a Provides filter rule to filter out auto-generated Provides from > libraries installed into "%{_libdir}/bitlbee". More information can be found > at https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering Fixed. Good catch! New links: https://fedorapeople.org/~gholms/review/bitlbee-steam-1.4.2-2.spec https://fedorapeople.org/~gholms/review/bitlbee-steam-1.4.2-2.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx