[Bug 1419027] Review Request: perl-Type-Tie - Tie a variable to a type constraint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1419027



--- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> ---
Source file is ok
Summary is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 
FIX: Please remove duplicity in BR unversioned 'perl(Exporter::Tiny)'
FIX: Please add build-requires:
  - perl(Moose::Util::TypeConstraints) - t/02moosextypes.t:32
  - perl(constant) - t/04nots.t:32

$ rpm -qp --requires perl-Type-Tie-0.009-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.1)
      1 perl(:VERSION) >= 5.8.5
      1 perl(Carp)
      1 perl(Exporter::Tiny)
      1 perl(Tie::Array)
      1 perl(Tie::Hash)
      1 perl(Tie::Scalar)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

FIX: Please add run-require 'perl(Data::Dumper)' - Tie.pm:100

$ rpm -qp --provides perl-Type-Tie-0.009-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Type::Tie) = 0.009
      1 perl(Type::Tie::ARRAY) = 0.009
      1 perl(Type::Tie::BASE) = 0.009
      1 perl(Type::Tie::HASH) = 0.009
      1 perl(Type::Tie::SCALAR) = 0.009
      1 perl-Type-Tie = 0.009-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Type-Tie*
perl-Type-Tie.noarch: W: spelling-error %description -l en_US ttie -> tie, t
tie
perl-Type-Tie.noarch: W: spelling-error %description -l en_US coercions ->
coercion, coercion's, coercion s
perl-Type-Tie.src: W: spelling-error %description -l en_US ttie -> tie, t tie
perl-Type-Tie.src: W: spelling-error %description -l en_US coercions ->
coercion, coercion's, coercion s
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok

License - most of the files are under "GPL+ or Artistic". However,
COPYRIGHT has different license. See COPYRIGHT:29-33
FIX: Please add license 'Public Domain'

Please correct all 'FIX' issues and provide new spec file.

Otherwise package looks good.
Not approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]