[Bug 1414216] Review Request: php-gettext-gettext - PHP gettext manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1414216

Remi Collet <rcollet@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcollet@xxxxxxxxxx



--- Comment #7 from Remi Collet <rcollet@xxxxxxxxxx> ---
Twig_Loader_String is only in twig v1 (and deprecated).
So you cannot use Twig 2.

BTW, removing the '/usr/share/php/Twig2/autoload.php' line from the autoloader
doesn't really solves the issue:

1) Gettext\Tests\AssetsTest::testTwig
TypeError: Argument 1 passed to Twig_Environment::compileSource() must be an
instance of Twig_Source, string given, called in
/dev/shm/extras/BUILDROOT/php-gettext-gettext-3.5.9-3.fc25.remi.x86_64/usr/share/php/Gettext/Extractors/Twig.php
on line 28

So definitively, this library is not ready for recent twig version (should
probably be reported upstream, I know twig is terribly managed, various BC
breaks in recent minor versions....)

So, for now, have to drop this optional dep... until fixed by upstream.

(sorry to have suggest you to add it ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]