[Bug 1418208] Review Request: perl-Class-Std-Fast - Faster but less secure replacement for Class::Std

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1418208



--- Comment #1 from Andrew Bauer <zonexpertconsulting@xxxxxxxxxxx> ---
Package builds in rawhide, package owns the files & folders it creates w/
proper permissions. 

https://koji.fedoraproject.org/koji/taskinfo?taskID=17545923


- I like how you handled the license, but I'm wondering if we ought to instead
reference the actual Perl license text, rather than gpl 3, since that is what
is referred to on the class:std::fast cpan site. 

See "The Perl 5 License (Artistic 1 & GPL 1)" -> http://dev.perl.org/licenses/

Doing that would then bring the license text in alignment with what is stated
in the License: field in the rpm specfile. 

This is just my opinion and I am not a lawyer, so feel free to respond as you
see fit.

- perl-generators is listed twice as a buildrequires

- rpmlint spotted trivial issues with the wording in the description as shown
below.

$ rpmlint perl-Class-Std-Fast-0.0.8-1.fc25.noarch.rpm
perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US ident ->
dent, indent, i dent
perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US
scalarifiyng -> scarification
perl-Class-Std-Fast.noarch: W: spelling-error %description -l en_US scalarify
-> scarify, clarify
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint perl-Class-Std-Fast-0.0.8-1.fc25.src.rpm
perl-Class-Std-Fast.src: W: spelling-error %description -l en_US ident -> dent,
indent, i dent
perl-Class-Std-Fast.src: W: spelling-error %description -l en_US scalarifiyng
-> scarification
perl-Class-Std-Fast.src: W: spelling-error %description -l en_US scalarify ->
scarify, clarify
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

In my opinion, this is what I would do:
"You can get the object's identity via scalar-ifying your object. Getting the
objects identity is still possible via the ident method"

rpmlint will still complain about that last "ident" but in that case the actual
name of the method is being referred to.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]