[Bug 1415143] Review Request: egl-wayland - Wayland EGL External Platform library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1415143



--- Comment #15 from Hans de Goede <hdegoede@xxxxxxxxxx> ---
HI,

(In reply to leigh scott from comment #12)
> (In reply to Hans de Goede from comment #11)
> > (In reply to leigh scott from comment #10)
> > > (In reply to Hans de Goede from comment #8)
> > > > Hi,
> > > > 
> > > > Ok, so we've 2 separate issues:
> > > > 
> > > > 1) Where to put the json file, since the json files points to
> > > > libnvidia-egl-wayland.so.1 to me the only sensible place is to package it
> > > > together with libnvidia-egl-wayland.so.1 . 
> > > 
> > > I believe the driver common (xorg-x11-drv-nvidia or nvidia-driver) should
> > > provide the json file as this file isn't really suitable for the common
> > > subpackage and can't go in the libs package as it would break multi arch
> > > install
> > 
> > The json file only specifies the relative filename, not the entire path, so
> > it wil be indentical on systems which have both lib and lib64 and as such
> > there is no multi-lib issues. Please just add the json file to the -libs
> > sub-package.
> 
> Try counting to ten then think about the file conflict it would generate :-)
> 
> egl-wayland-libs.x86_64
> egl-wayland-libs.i686

That is not how multi-lib works, if the file contents are the same there is no
conflict, otherwise all the /usr/share/doc/libfoo/COPYING files would all
conflict between there 32 and 64 bit version.

(In reply to leigh scott from comment #14)
> Another reason for including the 10_nvidia_wayland.json in the nvidia driver
> package is the lib would be advertising egl_external_platform.d capability
> when it has no chance of working due to missing nvidia driver.

The whole idea of the external_platform spec is that there might be other users
of the platform-providers, sure currently there are no other users, but that
also means that no other code will look at the json files so it won't hurt.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]