[Bug 1415143] Review Request: egl-wayland - Wayland EGL External Platform library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1415143



--- Comment #11 from Hans de Goede <hdegoede@xxxxxxxxxx> ---
(In reply to leigh scott from comment #10)
> (In reply to Hans de Goede from comment #8)
> > Hi,
> > 
> > Ok, so we've 2 separate issues:
> > 
> > 1) Where to put the json file, since the json files points to
> > libnvidia-egl-wayland.so.1 to me the only sensible place is to package it
> > together with libnvidia-egl-wayland.so.1 . 
> 
> I believe the driver common (xorg-x11-drv-nvidia or nvidia-driver) should
> provide the json file as this file isn't really suitable for the common
> subpackage and can't go in the libs package as it would break multi arch
> install

The json file only specifies the relative filename, not the entire path, so it
wil be indentical on systems which have both lib and lib64 and as such there is
no multi-lib issues. Please just add the json file to the -libs sub-package.

> > 2) We need some package to create / own the egl/egl_external_platform.d/
> > directories and this should not be nvidia specific since in theory in the
> > future there could be other providers. I'm not entirely happy about this but
> > I've to agree that the libglvnd-egl sub-package seems like the best place
> > for this. If everyone agrees I can make this change, and we can move forward
> > regardless as unowned directories are not really a big problem.
> >
> 
> The common sub-package addresses this issue

Looks good / works for me. Please do also add the %{sysconfdir} version of the
dir (/etc/...)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]