https://bugzilla.redhat.com/show_bug.cgi?id=1415143 --- Comment #5 from Simone Caronni <negativo17@xxxxxxxxx> --- (In reply to Hans de Goede from comment #4) > About the email discussion about the etc/egl/egl_external_platform.d and > /usr/share/egl/egl_external_platform.d directories and dropping a json file > there so that eglexternalplatform can actually find egl-wayland (if I've > understood things correctly): Not exactly. So, the Nvidia driver loads this library through their GL library: $ strings libEGL_nvidia.so.378.09 | grep egl_external /etc/egl/egl_external_platform.d:/usr/share/egl/egl_external_platform.d > I'm going to need some info on how all these new bits fit together. > > So egl-wayland is a (the wayland) platform provider for eglexternalplatform > right? Then it should also runtime depend on eglexternalplatform, either > through auto .so.x dependencies, or explicit in the spec I assume ? That folder is in the specification of eglexternalplatform. The Nvidia EGL library adheres to this, and tries to load the library from that folder with a json file: $ cat 10_nvidia_wayland.json { "file_format_version" : "1.0.0", "ICD" : { "library_path" : "libnvidia-egl-wayland.so.1" } } > Then to me it would make sense for the main eglexternalplatform pkg to > create/own the /etc/egl/egl_external_platform.d and > /usr/share/egl/egl_external_platform.d directories. This makes sense, but since eglexternalplatform is just a devel package with no library or anything else itself, I'm not sure if it makes sense to create an additional subpackage out of eglexternalplatform just to own an empty directory. Can we just maybe put it in the libglvnd-egl subpackage maybe with a note in the SPEC file? That package will always be installed on a system where the Nvidia proprietary glvnd/EGL library is installed. > I agree that if eglexternalplatform finds its platform providers / plugins > through json files, that the json file should be part of the package which > contains the .so file which contains the platform-provider implementation, > so in this specific case the main egl-wayland package. Exactly, so the full file list of egl-wayland should be as follows: $ rpm -qpl egl-wayland-1.0.0-0.2.20170120git743d702.fc26.x86_64.rpm /usr/lib64/libnvidia-egl-wayland.so.1 /usr/lib64/libnvidia-egl-wayland.so.1.0.0 /usr/share/doc/egl-wayland /usr/share/doc/egl-wayland/README.md /usr/share/egl/egl_external_platform.d/10_nvidia_wayland.json > About the egl-wayland package, I don't think it make sense to have a -devel > there as there are no headers and this is a plugin, depending on how the > json to load it refers to the .so, either drop the .so symlink or if it is > necessary make it part of the main pkg and add a comment to the %files > section why it is there. Makes sense. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx