Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cupsddk - CUPS Driver Development Kit https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248858 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-07-20 08:13 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for RPMs. But not silent for SRPM. Got following errors E: cupsddk hardcoded-library-path in /usr/lib/cups/filter A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. E: cupsddk hardcoded-library-path in /usr/lib/cups/filter/* A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. E: cupsddk hardcoded-library-path in /usr/lib/cups/driver/* A library path is hardcoded to one of the following paths: /lib, /usr/lib. It should be replaced by something like /%{_lib} or %{_libdir}. But above is false for our installation locations/paths. So I think above is ignorable. + source files match upstream. d35b74cbfaa4c48b0d650c34249bab6d cupsddk-1.2.0-source.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is small so no need of -doc subpackage. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc files are present. + -devel and -drivers subpackage exists. + no .la files. + no translations available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets used. + cupsddk-1.2.0-3.fc8 requires Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcrypt.so.1 libcups.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libm.so.6 libm.so.6(GLIBC_2.0) libpthread.so.0 libpthread.so.0(GLIBC_2.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libz.so.1 rtld(GNU_HASH) + cupsddk-devel-1.2.0-3.fc8 requires Requires: cupsddk = 1.2.0-3.fc8 + cupsddk-drivers-1.2.0-3.fc8 requires Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libcrypt.so.1 libcups.so.2 libcupsimage.so.2 libgcc_s.so.1 libgcc_s.so.1(GCC_3.0) libjpeg.so.62 libm.so.6 libm.so.6(GLIBC_2.0) libpng12.so.0 libpthread.so.0 libpthread.so.0(GLIBC_2.0) libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) libstdc++.so.6(GLIBCXX_3.4) libtiff.so.3 libz.so.1 rtld(GNU_HASH) + Not a GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review