https://bugzilla.redhat.com/show_bug.cgi?id=1413474 --- Comment #3 from Chris Lalancette <clalancette@xxxxxxxxx> --- (In reply to Filip Szymański from comment #2) > 1) When you set a tag Name, Version, Summary, URL, etc. a macro is created > %{name}, %{summary}, %{url}, ... > The summary global is unnecessary. Ah, I didn't realize that was the case. OK, I'll take that part of the patch then. Thanks. > > 2) Tests do not have to be part of the RPM package (or setup.py file) to be > run. > The build requires (pytest, genisoimage, etc.) and the %check section is all > you need. > > %check > PYTHONPATH=$RPM_BUILD_ROOT%{python2_sitelib} py.test-%{python2_version} -v > PYTHONPATH=$RPM_BUILD_ROOT%{python3_sitelib} py.test-%{python3_version} -v Hm, OK. When I enabled those parts of the RPM, I got some errors: Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.wD5Kvc + umask 022 + cd /home/clalancette/rpmbuild/BUILD + cd pycdlib-1.1.0 + PYTHONPATH=/home/clalancette/rpmbuild/BUILDROOT/python-pycdlib-1.1.0-0.20170201000812git7204e8b.fc25.x86_64/usr/lib/python2.7/site-packages + py.test-2.7 -v ============================= test session starts ============================== platform linux2 -- Python 2.7.13, pytest-2.9.2, py-1.4.32, pluggy-0.3.1 -- /usr/bin/python2 cachedir: .cache rootdir: /home/clalancette/rpmbuild/BUILD/pycdlib-1.1.0, inifile: collected 0 items ========================= no tests ran in 0.02 seconds ========================= error: Bad exit status from /var/tmp/rpm-tmp.wD5Kvc (%check) I'm on Fedora 25, x86_64. Any thoughts? > > 3) Ok. Cool. Thanks for your work on this so far! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx