[Bug 1404043] Review Request: rdma-core - RDMA core userspace libraries and daemons

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1404043

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zbyszek@xxxxxxxxx



--- Comment #27 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
systemd-units is long gone. You should replace:
Requires(post): systemd-units
Requires(preun): systemd-units
Requires(postun): systemd-units
→
%systemd_requires

Those Requires are generated automatically (when %post -p /sbin/ldconfig is
used). Can be removed:
Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig

It's better to not add files in /etc:
%config(noreplace) %{_sysconfdir}/udev/rules.d/*
→ %_udevrulesdir

%config(noreplace) %{_sysconfdir}/modprobe.d/mlx4.conf
%config(noreplace) %{_sysconfdir}/modprobe.d/truescale.conf
Are those really needed? If yes, then they should be in /usr/lib/modprobe.d.

See https://fedoraproject.org/wiki/Changes/UnversionedDocdirs.
%doc %{_docdir}/%{name}-%{version}/libibverbs.md
%doc %{_docdir}/%{name}-%{version}/rxe.md
should all have no %version suffix.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux