https://bugzilla.redhat.com/show_bug.cgi?id=1361883 Nils Philippsen <nphilipp@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(nphilipp@redhat.c | |om) | --- Comment #9 from Nils Philippsen <nphilipp@xxxxxxxxxx> --- Oh, hello 2017! ;) Sorry for the long wait. (In reply to Igor Gnatenko from comment #6) > (In reply to Nils Philippsen from comment #4) > > Thanks for taking the review! > > > > (In reply to Igor Gnatenko from comment #3) > > > > Requires: pkgconfig > > > not needed > > > > The pkgconfig package contains the %{_libdir}/pkgconfig directory and is > > normally used for building with the library. > There is automatic requirement for pkgconfig in RPM. Actually, rpm-build requires pkgconfig but we can't rely on that to be available -- people might want to build software against libmypaint without packaging it. > > > > %{_libdir}/girepository-1.0 > > > %dir %{_libdir}/girepository-1.0 > > > %{_libdir}/girepository-1.0/... specify here file > > > > > > same for gir directory > > > > Why? Listing the directory and the files separately, or just the directory > > recursively doesn't make a difference in the result. > It depends. For example, if they will add Gio-99.typelib into girepository > you will not notice by using '*'. Understood, I've added each file in these directories explicitly. Spec File: http://copr-dist-git.fedorainfracloud.org/cgit/nphilipp/gimp-unstable/libmypaint.git/plain/libmypaint.spec?h=f26&id=7f7d5d921449c4acbf33bc4c6f9ec071b84175d7 SRPM: https://copr-be.cloud.fedoraproject.org/results/nphilipp/gimp-unstable/fedora-26-x86_64/00504439-libmypaint/libmypaint-1.3.0-0.4.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx