[Bug 1410901] Review Request: python-fmn - A system for generic fedmsg-driven notifications for end users

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1410901

Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(jeremy@xxxxxxxxxx
                   |                            |)



--- Comment #3 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> ---
I believe the Provides statements should be using the release, but even more
importantly should be using the version macro. Otherwise, this package will
always claim to provide the other packages at the versions they were retired
at, which won't be true since it will be changing over time.

For example, instead of:

Provides: python-fmn-rules = 0.9.1

I think you need:

Provides: python-fmn-rules = %{version}-%{release}

You can read a bit about that here:

https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages

Here's an example spec file that uses a global for the description:

http://pkgs.fedoraproject.org/cgit/rpms/python-nose.git/tree/python-nose.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]