[Bug 1409355] Review Request: rubygem-tk - Tk interface module using tcltklib

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409355



--- Comment #1 from František Dvořák <valtri@xxxxxxxxxx> ---
It looks like, there is a problem with stability. I've tested:

/usr/share/gems/gems/tk-0.1.1/sample/demos-en/widget dialog2

And there are two problems:

1) Occasionally there is a cryptic error message:

  invalid command name ".w00010.msg"

This message occurs also on F25 (with both: ruby-tcltk package, or recompiled
rubygem-tk), so this is already existing problem (not a show-stopper for
upgrade from ruby-tcltk).

2) When closing the demo window, ruby crashes.

Ruby won't crash in F25, so this is a new problem with F26.

I'm not sure, what to do with the second problem. Continue with packaging and
report upstream? It is possible it is only bug in the demo code? (there are
used threads, ...).


Now the packaging itself, the easier part: :-)

3) the modification of gem.build_complete

It is interesting way, how to solve the rpmlint error. But the real fix
probably belongs to the rpmlint. Maybe it could be better to know about it in
the bodhi tests (and keep the error)?

Another way (without the real fix though) could be to use ".rpmlint" config
file in the fedora git package sources.

4) gcc dependency is not needed

5) it could be safer to replace '/usr/local' and '/usr/bin/env ruby' only in
'sample' subdirectory (just a hint to consider, checking everything is probably
fine and desired?)

6) missing the "Provides: ruby-tcltk"

There is comment about it, so it is probably OK a there is reason for it (not
full functionality provided by 'tk' gem?). I've noticed there is still a TCL
part available - at least the variable Tk::TCL_VERSION.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]