https://bugzilla.redhat.com/show_bug.cgi?id=1415731 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive (SHA-256: 78560b638016ef047fd5937f2d35cca9536fe5b42a03974e173f16671bf5c397) is original. Ok. Summary verified from PerlData.pm. Ok. Description verified from PerlData.pm. Ok. License verified from PerlData.pm, Makefile.PL. Ok. TODO: Recommend upstream to remove the misleading "under the Perl Artistic Licence" statement because "Perl Artistic Licence" does not include GPL. No XS code, noarch BuildArch is Ok. BuildRequires are Ok. All tests pass. Ok. $ rpmlint perl-XML-Generator-PerlData.spec ../SRPMS/perl-XML-Generator-PerlData-0.95-1.fc26.src.rpm ../RPMS/noarch/perl-XML-Generator-PerlData-0.95-1.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-XML-Generator-PerlData-0.95-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Jan 24 11:06 /usr/share/doc/perl-XML-Generator-PerlData -rw-r--r-- 1 root root 903 Jan 24 11:06 /usr/share/doc/perl-XML-Generator-PerlData/Changes -rw-r--r-- 1 root root 260 Nov 13 2014 /usr/share/doc/perl-XML-Generator-PerlData/TODO -rw-r--r-- 1 root root 7615 Jan 24 11:06 /usr/share/man/man3/XML::Generator::PerlData.3pm.gz drwxr-xr-x 2 root root 0 Jan 24 11:06 /usr/share/perl5/vendor_perl/XML drwxr-xr-x 2 root root 0 Jan 24 11:06 /usr/share/perl5/vendor_perl/XML/Generator -rw-r--r-- 1 root root 49101 Oct 2 2015 /usr/share/perl5/vendor_perl/XML/Generator/PerlData.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-XML-Generator-PerlData-0.95-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 perl(XML::SAX::Base) >= 1.02 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-XML-Generator-PerlData-0.95-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(XML::Generator::PerlData) = 0.95 1 perl-XML-Generator-PerlData = 0.95-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-XML-Generator-PerlData-0.95-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17400487). Ok. The package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx