https://bugzilla.redhat.com/show_bug.cgi?id=1411984 Dylan Araps <dylan.araps@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dylan.araps@xxxxxxxxx --- Comment #8 from Dylan Araps <dylan.araps@xxxxxxxxx> --- Hiya, thanks for packaging Neofetch. I've got a few suggestions: **Required Dependencies** Neofetch only requires `bash` to function. The only other required dependencies are `awk`, `grep` and `uname`. While these **are** also required programs they're guaranteed to be installed already so I don't bother listing them. You can confirm this by unsetting `$PATH` and re-declaring it with only the 4 programs above. \[1\] Every other dependency is optional and neofetch will just not display information for that function if a program is missing. What I propose for your package is making `bash` the only required dependency. Right now this spec file makes neofetch have an indirect dependency on the X server. I'm packaging neofetch for Arch Linux this way and then listing all other dependencies as 'Optional'. \[2\] **Neofetch 3.0** Neofetch 3.0 was released yesterday which introduced the POSIX Makefile so it *should* work without modification on your side now. \[1\]https://gist.githubusercontent.com/dylanaraps/9343178c7792db3c92414a8a6076285e/raw/245d8a2c1c7ee4558264a65188f0831220b1dd49/path.sh \[2\] https://aur.archlinux.org/packages/neofetch/ Thanks! :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx