Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Text-Diff-HTML - XHTML format for Text::Diff::Unified https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248396 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-07-20 00:00 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url cd8a50dd2f9d90be1f949906441035c1 Text-Diff-HTML-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs t/base....ok t/pod.....ok All tests successful. Files=2, Tests=9, 1 wallclock secs ( 0.12 cusr + 0.03 csys = 0.15 CPU) + Provides: perl(Text::Diff::HTML) = 0.04 + Requires: perl(:MODULE_COMPAT_5.8.8) perl(HTML::Entities) perl(Text::Diff) perl(constant) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review