https://bugzilla.redhat.com/show_bug.cgi?id=1415663 Igor Gnatenko <ignatenko@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "FSF All Permissive", "GPL (v2 or later)", "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /home/brain/tmp/review-kbdd/licensecheck.txt -> This is partially false-positive, because INSTALL file is FSF All Permissive... -> All (almost) source code files have headers for GPLv2+, but COPYING file says GPLv3+, please file ticket to upstream to clarify it. Not blocking on this, because GPLv2+ includes GPLv3+, so it should be fine for now, but add link in spec about upstream ticket. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dbus-1, /usr/share/dbus-1/interfaces -> Add Requires: dbus licensecheck: FSF All Permissive ------------------ kbdd-0.7.1/INSTALL GPL (v2 or later) ----------------- kbdd-0.7.1/src/common-defs.h kbdd-0.7.1/src/dbus/dbus-test.c kbdd-0.7.1/src/dbus/m-kbdd-service.c kbdd-0.7.1/src/dbus/m-kbdd-service.h kbdd-0.7.1/src/kbdd.c kbdd-0.7.1/src/libkbdd.c kbdd-0.7.1/src/libkbdd.h kbdd-0.7.1/src/perwindow.c kbdd-0.7.1/src/perwindow.h Unknown or generated -------------------- kbdd-0.7.1/AUTHORS kbdd-0.7.1/COPYING kbdd-0.7.1/ChangeLog kbdd-0.7.1/Makefile.am kbdd-0.7.1/NEWS kbdd-0.7.1/README kbdd-0.7.1/README.rst kbdd-0.7.1/bump.sh kbdd-0.7.1/configure.ac kbdd-0.7.1/kbdd.1 kbdd-0.7.1/src/Makefile.am kbdd-0.7.1/src/dbus/Makefile.am kbdd-0.7.1/src/dbus/kbdd-service-interface.xml kbdd-0.7.1/src/keys.h -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx