https://bugzilla.redhat.com/show_bug.cgi?id=1409866 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #10 from Petr Pisar <ppisar@xxxxxxxxxx> --- This is a rebase, a complete new review follows. URL and Source0 address are usable. Ok. Source archive is original (SHA-256: 83f3d276849107b9f4fbef20d3d2849e3c751d751cfdfa67316470e9974543a7). Ok. Summary is Ok. Description is Ok. License verified from SunTime.pm and README. Ok. Build-time dependencies are Ok. All tests pass. Ok. $ rpmlint perl-Astro-SunTime.spec ../SRPMS/perl-Astro-SunTime-0.05-1.fc26.src.rpm ../RPMS/noarch/perl-Astro-SunTime-0.05-1.fc26.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -l -v -p ../RPMS/noarch/perl-Astro-SunTime-0.05-1.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Jan 23 10:22 /usr/share/doc/perl-Astro-SunTime -rw-r--r-- 1 root root 192 Jan 3 23:43 /usr/share/doc/perl-Astro-SunTime/Changes -rw-r--r-- 1 root root 288 Jan 20 19:20 /usr/share/doc/perl-Astro-SunTime/README drwxr-xr-x 2 root root 0 Jan 23 10:22 /usr/share/perl5/vendor_perl/Astro -r--r--r-- 1 root root 3723 Jan 20 19:20 /usr/share/perl5/vendor_perl/Astro/SunTime.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Astro-SunTime-0.05-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(POSIX) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -q --requires -p ../RPMS/noarch/perl-Astro-SunTime-0.05-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(POSIX) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: The `perl(Time::ParseDate)' is missing from run-time dependencies. The code loads it optionally, but without having the module installed, the code crashes: $ perl -Iblib/lib -e "use Astro::SunTime; sun_time(type => 'rise', latitude => 40, longitude => -77, time_zone => -5, date => '1 Jan 1970')" Undefined subroutine &Astro::SunTime::parsedate called at blib/lib/Astro/SunTime.pm line 41. Therefere I recommend to run-require it explicitly. Or you can make the run-time dependency optional by using `Recommends:' instead of `Requires:' keyword. $ rpm -q --provides -p ../RPMS/noarch/perl-Astro-SunTime-0.05-1.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Astro::SunTime) = 0.05 1 perl-Astro-SunTime = 0.05-1.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Astro-SunTime-0.05-1.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17389376). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' item before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx