https://bugzilla.redhat.com/show_bug.cgi?id=1413434 --- Comment #3 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- > The upstream project already has an autoloader.php Indeed, I miss it. > Also, I realized that it seems that they may expect that bin/export.{php,sh} to get distributed with the package Indeed (reading the README) Notice: this means that the comopser.json is incomplete, should have this listed in the "bin" section (ex, see https://github.com/sebastianbergmann/phpunit/blob/5.7/composer.json#L61). => could be submitted upstream The .sh is uneeded, (the .php with a propoer shebang is enough) => using "#!/usr/bin/env php" can be submitted upstream. (Fedora Guidelines, recommends #!/usr/bin/php, but using env is also ok, if you require php-cli, at least this allow the command to work with SCL... even if this is more correct outside Fedora). > Do you think we should distribute that executable? yes > If so, should I name it something more specific (gettext-languages-export.sh, cldr-to-gettext-plural-rules-export.sh?) Yes. "%{name}-export" seems ok (no suffix) > but if we want to distribute it I'll need to sed a copy of it instead (and sed the one we install separately). Indeed. Patch it in %prep for installation Patch it again in %check. >From php-nikic-php-parser sed -e 's:%{php_home}:%{buildroot}%{php_home}:' \ bin/php-parse > bin/php-parse-test -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx