https://bugzilla.redhat.com/show_bug.cgi?id=1414027 Christian Dersch <lupinix@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Christian Dersch <lupinix@xxxxxxxxxxx> --- Approved, just found two minor issues you have to fix on import. Issues: ======= 1.) You should require hicolor-icon-theme (directory ownership) 2.) The postun scriptlet is broken (missing fi at the end) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. ==> Unversioned so files are plugins => fine [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL (v2)", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated", "GPL (v2 or v3)", "GPL (v2 or later) (with Qt exception)", "GPL (v2.0)", "GPL (v2) (with Qt exception)", "GPL (v2)". 37 files have unknown license. Detailed output of licensecheck in /home/review/1414027-kmail/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/22x22/apps, /usr/share/icons/hicolor/32x32/apps, /usr/share/kservices5/kontact, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/64x64, /usr/share/kontact, /usr/share/kontact/ksettingsdialog, /usr/share/dbus-1/interfaces, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor, /usr/share/icons/hicolor/22x22/actions, /usr/share/dbus-1, /usr/share/config.kcfg, /usr/share/icons/hicolor/128x128, /usr/share/doc/HTML, /usr/share/icons/hicolor/32x32, /usr/share/doc/HTML/en, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/22x22, /usr/share/icons/hicolor/48x48, /usr/share/kxmlgui5 [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/kmail2/pics(kmail, kdepim-common), /usr/share/kxmlgui5/kontactsummary(kontact), /usr/share/kmail2(kmail, kdepim-common) ==> This is a reault of packaging change starting with 16.12.x [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in kmail [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. ===> ExclusiveArch: %{qt5_qtwebengine_arches} is in spec, we need that as qt5-qtwebengine is limited to some architectures => fine [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kmail- libs , kmail-debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Scriptlets must be sane, if used. ==> postun for kmail is broken, missing fi at end [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. ==> As mentioned above we are limited to the architectures supported by qt5-qtwebengine. spec uses ExclusiveArch: %{qt5_qtwebengine_arches} as required. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1986560 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kmail-16.12.1-3.fc26.x86_64.rpm kmail-libs-16.12.1-3.fc26.x86_64.rpm kmail-debuginfo-16.12.1-3.fc26.x86_64.rpm kmail-16.12.1-3.fc26.src.rpm kmail.x86_64: W: non-conffile-in-etc /etc/xdg/kmail.renamecategories kmail.x86_64: W: non-conffile-in-etc /etc/xdg/kmail.categories kmail.x86_64: W: non-conffile-in-etc /etc/xdg/ktnef.categories kmail.x86_64: W: no-manual-page-for-binary ktnef kmail.x86_64: W: no-manual-page-for-binary akonadi_archivemail_agent kmail.x86_64: W: no-manual-page-for-binary kmail kmail.x86_64: W: no-manual-page-for-binary akonadi_sendlater_agent kmail.x86_64: W: no-manual-page-for-binary akonadi_mailfilter_agent kmail.x86_64: W: no-manual-page-for-binary akonadi_followupreminder_agent kmail.x86_64: E: shell-syntax-error-in-%postun kmail-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment kmail-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment kmail-libs.x86_64: W: no-documentation kmail.src:103: W: macro-in-comment %{majmin_ver} 4 packages and 0 specfiles checked; 1 errors, 13 warnings. ===> Fix the scriptlet Rpmlint (debuginfo) ------------------- Checking: kmail-debuginfo-16.12.1-3.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory kmail.x86_64: W: non-conffile-in-etc /etc/xdg/kmail.categories kmail.x86_64: W: non-conffile-in-etc /etc/xdg/kmail.renamecategories kmail.x86_64: W: non-conffile-in-etc /etc/xdg/ktnef.categories kmail.x86_64: W: no-manual-page-for-binary akonadi_archivemail_agent kmail.x86_64: W: no-manual-page-for-binary akonadi_followupreminder_agent kmail.x86_64: W: no-manual-page-for-binary akonadi_mailfilter_agent kmail.x86_64: W: no-manual-page-for-binary akonadi_sendlater_agent kmail.x86_64: W: no-manual-page-for-binary kmail kmail.x86_64: W: no-manual-page-for-binary ktnef kmail.x86_64: E: shell-syntax-error-in-%postun kmail-libs.x86_64: W: spelling-error Summary(en_US) Runtime -> Run time, Run-time, Rudiment kmail-libs.x86_64: W: spelling-error %description -l en_US Runtime -> Run time, Run-time, Rudiment kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libKF5Solid.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libgpgme.so.11 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libKF5Ldap.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libKF5Wallet.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libKF5Auth.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libKF5Service.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libKF5KManageSieve.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libKF5KSieve.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libQt5WebEngineWidgets.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libQt5WebEngineCore.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libQt5WebChannel.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libQt5Positioning.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libQt5Quick.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libQt5Qml.so.5 kmail-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libkmailprivate.so.5.4.1 /lib64/libm.so.6 kmail-libs.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 27 warnings. Requires -------- kmail (rpmlib, GLIBC filtered): /bin/sh kmail-libs(x86-64) libKF5AkonadiAgentBase.so.5()(64bit) libKF5AkonadiContact.so.5()(64bit) libKF5AkonadiCore.so.5()(64bit) libKF5AkonadiMime.so.5()(64bit) libKF5AkonadiWidgets.so.5()(64bit) libKF5Auth.so.5()(64bit) libKF5Bookmarks.so.5()(64bit) libKF5CalendarCore.so.5()(64bit) libKF5Codecs.so.5()(64bit) libKF5Completion.so.5()(64bit) libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5ConfigWidgets.so.5()(64bit) libKF5Contacts.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Crash.so.5()(64bit) libKF5DBusAddons.so.5()(64bit) libKF5FollowupReminder.so.5()(64bit) libKF5GuiAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5IconThemes.so.5()(64bit) libKF5IdentityManagement.so.5()(64bit) libKF5ItemModels.so.5()(64bit) libKF5ItemViews.so.5()(64bit) libKF5JobWidgets.so.5()(64bit) libKF5KDELibs4Support.so.5()(64bit) libKF5KIOCore.so.5()(64bit) libKF5KIOFileWidgets.so.5()(64bit) libKF5KIOWidgets.so.5()(64bit) libKF5KontactInterface.so.5()(64bit) libKF5Libkdepim.so.5()(64bit) libKF5Libkleo.so.5()(64bit) libKF5MailCommon.so.5()(64bit) libKF5MailTransport.so.5()(64bit) libKF5MessageComposer.so.5()(64bit) libKF5MessageCore.so.5()(64bit) libKF5Mime.so.5()(64bit) libKF5Notifications.so.5()(64bit) libKF5Parts.so.5()(64bit) libKF5PimCommon.so.5()(64bit) libKF5PimTextEdit.so.5()(64bit) libKF5SendLater.so.5()(64bit) libKF5Service.so.5()(64bit) libKF5Solid.so.5()(64bit) libKF5SonnetUi.so.5()(64bit) libKF5TemplateParser.so.5()(64bit) libKF5TextWidgets.so.5()(64bit) libKF5Tnef.so.5()(64bit) libKF5UnitConversion.so.5()(64bit) libKF5Wallet.so.5()(64bit) libKF5WidgetsAddons.so.5()(64bit) libKF5WindowSystem.so.5()(64bit) libKF5XmlGui.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5PrintSupport.so.5()(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgpgme.so.11()(64bit) libgpgmepp.so.6()(64bit) libical.so.2()(64bit) libicalss.so.2()(64bit) libkmailprivate.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libqgpgme.so.7()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) kmail-debuginfo (rpmlib, GLIBC filtered): kmail-libs (rpmlib, GLIBC filtered): /sbin/ldconfig kmail libKF5AkonadiContact.so.5()(64bit) libKF5AkonadiCore.so.5()(64bit) libKF5AkonadiMime.so.5()(64bit) libKF5AkonadiSearchDebug.so.5()(64bit) libKF5AkonadiSearchPIM.so.5()(64bit) libKF5AkonadiWidgets.so.5()(64bit) libKF5Auth.so.5()(64bit) libKF5Bookmarks.so.5()(64bit) libKF5CalendarCore.so.5()(64bit) libKF5CalendarUtils.so.5()(64bit) libKF5Codecs.so.5()(64bit) libKF5Completion.so.5()(64bit) libKF5ConfigCore.so.5()(64bit) libKF5ConfigGui.so.5()(64bit) libKF5ConfigWidgets.so.5()(64bit) libKF5Contacts.so.5()(64bit) libKF5CoreAddons.so.5()(64bit) libKF5Crash.so.5()(64bit) libKF5FollowupReminder.so.5()(64bit) libKF5Gravatar.so.5()(64bit) libKF5GuiAddons.so.5()(64bit) libKF5I18n.so.5()(64bit) libKF5IconThemes.so.5()(64bit) libKF5IdentityManagement.so.5()(64bit) libKF5ItemModels.so.5()(64bit) libKF5ItemViews.so.5()(64bit) libKF5JobWidgets.so.5()(64bit) libKF5KCMUtils.so.5()(64bit) libKF5KDELibs4Support.so.5()(64bit) libKF5KIOCore.so.5()(64bit) libKF5KIOFileWidgets.so.5()(64bit) libKF5KIOWidgets.so.5()(64bit) libKF5KManageSieve.so.5()(64bit) libKF5KSieve.so.5()(64bit) libKF5KSieveUi.so.5()(64bit) libKF5KontactInterface.so.5()(64bit) libKF5Ldap.so.5()(64bit) libKF5Libkdepim.so.5()(64bit) libKF5Libkleo.so.5()(64bit) libKF5MailCommon.so.5()(64bit) libKF5MailTransport.so.5()(64bit) libKF5MessageComposer.so.5()(64bit) libKF5MessageCore.so.5()(64bit) libKF5MessageList.so.5()(64bit) libKF5MessageViewer.so.5()(64bit) libKF5Mime.so.5()(64bit) libKF5MimeTreeParser.so.5()(64bit) libKF5Notifications.so.5()(64bit) libKF5NotifyConfig.so.5()(64bit) libKF5Parts.so.5()(64bit) libKF5PimCommon.so.5()(64bit) libKF5PimTextEdit.so.5()(64bit) libKF5SendLater.so.5()(64bit) libKF5Service.so.5()(64bit) libKF5Solid.so.5()(64bit) libKF5SonnetUi.so.5()(64bit) libKF5TemplateParser.so.5()(64bit) libKF5TextWidgets.so.5()(64bit) libKF5UnitConversion.so.5()(64bit) libKF5Wallet.so.5()(64bit) libKF5WebEngineViewer.so.5()(64bit) libKF5WidgetsAddons.so.5()(64bit) libKF5WindowSystem.so.5()(64bit) libKF5XmlGui.so.5()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.7)(64bit) libQt5DBus.so.5()(64bit) libQt5DBus.so.5(Qt_5)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Positioning.so.5()(64bit) libQt5PrintSupport.so.5()(64bit) libQt5Qml.so.5()(64bit) libQt5Quick.so.5()(64bit) libQt5WebChannel.so.5()(64bit) libQt5WebEngineCore.so.5()(64bit) libQt5WebEngineWidgets.so.5()(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libQt5Xml.so.5()(64bit) libQt5Xml.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgpgme.so.11()(64bit) libgpgmepp.so.6()(64bit) libical.so.2()(64bit) libicalss.so.2()(64bit) libkmailprivate.so.5()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libqgpgme.so.7()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) Provides -------- kmail: appdata() appdata(org.kde.kmail.appdata.xml) application() application(kmail_view.desktop) application(org.kde.kmail.desktop) application(org.kde.ktnef.desktop) kmail kmail(x86-64) mimehandler(application/mbox) mimehandler(application/ms-tnef) mimehandler(application/x-mimearchive) mimehandler(message/rfc822) mimehandler(x-scheme-handler/mailto) kmail-debuginfo: kmail-debuginfo kmail-debuginfo(x86-64) kmail-libs: kmail-libs kmail-libs(x86-64) libkmailprivate.so.5()(64bit) Unversioned so-files -------------------- kmail-libs: /usr/lib64/qt5/plugins/kcm_kmail.so kmail-libs: /usr/lib64/qt5/plugins/kcm_kmailsummary.so kmail-libs: /usr/lib64/qt5/plugins/kcm_kontactsummary.so kmail-libs: /usr/lib64/qt5/plugins/kcm_kpimidentities.so kmail-libs: /usr/lib64/qt5/plugins/kmailpart.so kmail-libs: /usr/lib64/qt5/plugins/kontact_kmailplugin.so kmail-libs: /usr/lib64/qt5/plugins/kontact_summaryplugin.so Source checksums ---------------- http://download.kde.org/stable/applications/16.12.1/src/kmail-16.12.1.tar.xz : CHECKSUM(SHA256) this package : 946b3e42a415335e549443d1cf2c3163b240079a09a96dc80a87ff9c6af3a76f CHECKSUM(SHA256) upstream package : 946b3e42a415335e549443d1cf2c3163b240079a09a96dc80a87ff9c6af3a76f Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1414027 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx