[Bug 1412801] Review Request: python-networkmanager - Easy communication with NetworkManager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1412801

Igor Gnatenko <ignatenko@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|                            |fedora-review+



--- Comment #3 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
* %doc %{_mandir}/man1/python-networkmanager.1.gz ->
%{_mandir}/man1/python-networkmanager.1*
* cp docs/_build/man/python-networkmanager.1 %{buildroot}%{_mandir}/man1/
  -> this doesn't preserve timestamps actually
* %files -n python-networkmanager-doc
  -> I don't think it's worth to create subpackage for this (examples are not
that big, but metadata which is created is bigger ;))
* Since you share man between to packages, you should add Conflicts:
pythonX-networkmanager < %{version}-%{release} and Conflicts:
pythonX-networkmanager > %{version}-%{release}
  -> otherwise if people will try to update packages separately, it will fail
with file errors
* Since you already share files, I would recommend to set %global _docdir_fmt
%{name}, so all documentation will be shared in one directory

Don't see any blockers though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]