https://bugzilla.redhat.com/show_bug.cgi?id=1415190 Bug ID: 1415190 Summary: Review Request: python-onionbalance - Load-balancing for Tor onion services Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: mh+fedora@xxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: http://git.scrit.ch/srpm/python-onionbalance/plain/SPECS/python-onionbalance.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/3105/17343105/python-onionbalance-0.1.6-1.fc26.src.rpm Description: OnionBalance provides load-balancing and redundancy for Tor onion services by distributing requests to multiple back-end Tor instances. Fedora Account System Username: maha This package is intended to be built for rawhide, as well as EPEL7. Scratch build for Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=17343105 Scratch build for F26: https://koji.fedoraproject.org/koji/taskinfo?taskID=17343163 There are some rpmlint warnings and errors, which I think do not apply for this package. My comments are: >> python2-onionbalance.noarch: W: no-documentation >> python2-onionbalance.noarch: W: no-manual-page-for-binary onionbalance-py2 >> python2-onionbalance.noarch: W: no-manual-page-for-binary onionbalance-config-py2 this is by intend, as the python3 package contains all the documentation and manpages. I wasn't sure whether this is the right way to package the python2 variant of the service. >> python3-onionbalance.noarch: W: non-standard-gid /etc/onionbalance toranon >> python3-onionbalance.noarch: E: non-standard-dir-perm /etc/onionbalance 750 This is by intend, as this directory will contain sensitive information. >> python3-onionbalance.noarch: W: devel-file-in-non-devel-package /usr/bin/onionbalance-config I'm not sure, why rpmlint thinks this is a devel file. >> python3-onionbalance.noarch: W: non-standard-uid /var/lib/onionbalance onionbalance >> python3-onionbalance.noarch: W: non-standard-gid /var/lib/onionbalance toranon >> python3-onionbalance.noarch: E: non-standard-dir-perm /var/lib/onionbalance 750 This is by intend, as it might contain sensitive information. >>> python3-onionbalance.noarch: W: non-standard-uid /var/log/onionbalance onionbalance >> python3-onionbalance.noarch: W: non-standard-gid /var/log/onionbalance toranon >> python3-onionbalance.noarch: E: non-standard-dir-perm /var/log/onionbalance 750 This is by intend, as the logfile might contain sensitive information. >> python3-onionbalance.noarch: E: incoherent-logrotate-file /etc/logrotate.d/onionbalance.conf This is by intend, as it then follows: https://fedoraproject.org/wiki/Packaging:Guidelines#Logrotate_config_file What follows is the full output of rpmlint: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/python* python2-onionbalance.noarch: W: no-documentation python2-onionbalance.noarch: W: no-manual-page-for-binary onionbalance-config-py2 python2-onionbalance.noarch: W: no-manual-page-for-binary onionbalance-py2 python3-onionbalance.noarch: E: incoherent-logrotate-file /etc/logrotate.d/onionbalance.conf python3-onionbalance.noarch: W: non-standard-uid /var/log/onionbalance onionbalance python3-onionbalance.noarch: W: non-standard-gid /var/log/onionbalance toranon python3-onionbalance.noarch: E: non-standard-dir-perm /var/log/onionbalance 750 python3-onionbalance.noarch: W: non-standard-uid /var/lib/onionbalance onionbalance python3-onionbalance.noarch: W: non-standard-gid /var/lib/onionbalance toranon python3-onionbalance.noarch: E: non-standard-dir-perm /var/lib/onionbalance 750 python3-onionbalance.noarch: W: devel-file-in-non-devel-package /usr/bin/onionbalance-config python3-onionbalance.noarch: W: non-standard-gid /etc/onionbalance toranon python3-onionbalance.noarch: E: non-standard-dir-perm /etc/onionbalance 750 3 packages and 0 specfiles checked; 4 errors, 9 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx