https://bugzilla.redhat.com/show_bug.cgi?id=1410651 Daniel Moerner <dmoerner@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmoerner@xxxxxxxxx --- Comment #1 from Daniel Moerner <dmoerner@xxxxxxxxx> --- Hi, This is a non-official package review. Just trying to get involved :). This looks very good to me. I can't find any particular problems. Note that I wrote a manpage which you can include, see below. Versioning: I worried a bit about the versioning in case upstream decides to issue a proper release, but I see that upstream does have a single git tag with a date, and which they used as the version for a Windows release, and which is the tag you used for this release. So this is probably fine. Relevant fedora-review output: Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 ^ As confirmed on IRC with nirik, this is actually seems to be a bug in fedora-review. It is correct to list gcc-c++ as a BR, per https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires I have filed a bug against fedora-review: https://bugzilla.redhat.com/show_bug.cgi?id=1414065 Rpmlint ------- Checking: minetestmapper-20161218-1.fc25.x86_64.rpm minetestmapper-debuginfo-20161218-1.fc25.x86_64.rpm minetestmapper-20161218-1.fc25.src.rpm minetestmapper.x86_64: W: spelling-error %description -l en_US py -> pt, p, y minetestmapper.x86_64: W: no-manual-page-for-binary minetestmapper minetestmapper.src: W: spelling-error Summary(en_US) minetest -> minutest, mine test, mine-test minetestmapper.src: W: spelling-error %description -l en_US minetest -> minutest, mine test, mine-test minetestmapper.src: W: spelling-error %description -l en_US py -> pt, p, y 3 packages and 0 specfiles checked; 0 errors, 5 warnings. ^ The spelling errors are fine. But manpages are good, so I wrote a manpage! I filed a pull request with upstream: https://github.com/minetest/minetestmapper/pull/43 You are of course welcome to include the manpage in the Fedora package itself before upstream releases a new version. Here's a direct link: https://github.com/dmoerner/minetestmapper/blob/master/minetestmapper.6 The manpage does include a reference to postgresql support, which is in upstream master but not in 20161218. So if you want to include it you should remove that. (sed -i 's/\*postgresql\*, //' minetestmapper.6) Daniel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx