[Bug 1409382] Review Request: python36 - Version 3.6 of the Python programming language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409382



--- Comment #1 from Iryna Shcherbina <ishcherb@xxxxxxxxxx> ---
-----
NOTES
-----
Upgrade path is clean from F24 to F25.

Rewheel mode is removed. [0]
Debug build is disabled. [1]

[0]
https://github.com/fedora-python/python36/commit/b5cda81775024ea2c7c74515f3593d7a5022a8fc
[1]
https://github.com/fedora-python/python36/commit/51bf9a17b445c120fbcc603246205ea225533f69

Package is flat, meaning that there are no subpackages, all the files and
directories are at the main package.

Binaries, libraries and man pages, which conflict with the system python3
package, are removed or renamed. The binary for this package is renamed to
python36.

python(abi) is not required/provided.

python3-setuptools and python3-pip come bundled with this package, so to comply
with the packaging guidelines, virtual provides are added:

$ rpm -q --provides python36
bundled(python3-pip) = 9.0.1
bundled(python3-setuptools) = 28.8.0
...

Libraries are installed into %{_libdir}/python3.6, so there is no conflict with
%{_libdir}/python3.5 at F24 and F25.


Tested on F24 virtual machine, which I upgraded to F25. No issues observed and
nothing conflicts with base python package.
Invoking 'python3' command fires up the python 3.5.1 (F24) or 3.5.2 (F25)
shell, and 'python36' - 3.6.0 shell.
Doing some more testing before approving the package.

-------
RPMLINT
-------
$ rpmlint python36-3.6.0-1.fc25.src.rpm 
python36.src:205: W: macro-in-comment %{_lib}
python36.src:388: W: macro-in-comment %{pybasever}
python36.src:622: E: hardcoded-library-path in %{_prefix}/lib/debug/%{_libdir}
python36.src:668: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}/site-packages/__pycache__
python36.src:705: W: macro-in-comment %{_pyconfig32_h}
python36.src:707: W: macro-in-comment %{_pyconfig64_h}
python36.src:769: W: macro-in-comment %{pylibdir}
python36.src:829: E: use-of-RPM_SOURCE_DIR
python36.src:952: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}
python36.src:953: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}/site-packages
python36.src:954: E: hardcoded-library-path in
%{_prefix}/lib/python%{pybasever}/site-packages/__pycache__/
python36.src:40: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line
40)
python36.src: W: patch-not-applied Patch146: 00146-hashlib-fips.patch
1 packages and 0 specfiles checked; 6 errors, 7 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]