[Bug 1411188] Review Request: php-echonest-api - PHP classes for the Echo Nest API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1411188

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?



--- Comment #7 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> ---
Blockers:

[!]: Requires correct, justified where necessary.
    PHP virtual provides for extensions (curl, spl, ...) doesn't have version,
    so you should not use version in requires (doesn't make sense for most of
ext.)
    Only php(language) should have a version.

[!]: Package complies to the Packaging Guidelines
    See https://fedoraproject.org/wiki/Packaging:Versioning
    So Release should be 0.<seq. number>.20131228git%{short_commit}%{?dist}

[!]: Rpmlint is run on all installed packages.
    Drop excution right on all php scripts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]