https://bugzilla.redhat.com/show_bug.cgi?id=1411984 herdiansyah@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |herdiansyah@xxxxxxxxxxxxxxx --- Comment #3 from herdiansyah@xxxxxxxxxxxxxxx --- Hello, I am one of the contributors of neofetch, and the maintainer for the third-party package for neofetch in copr. My only concern will be in >%install Since neofetch does have a Makefile, won't it be better to use %make_install instead of copying the files manually? Also, for > %{_datadir}/%{name}/ascii/distro/* > %{_datadir}/%{name}/config We can simplify it to %{_datadir}/%{name}/* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx