https://bugzilla.redhat.com/show_bug.cgi?id=1412128 --- Comment #6 from Thomas Andrejak <thomas.andrejak@xxxxxxxxx> --- SPEC : https://fedorapeople.org/~totol/libpreludedb.spec SRPM : https://fedorapeople.org/~totol/libpreludedb-3.1.0-26.fc26.src.rpm (In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > Summary right now basically repeats the name. Something like "database to > store IDMEF alerts" would be better. Done (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > (In reply to Thomas Andrejak from comment #3) > > > > Provides: %{name}%{?_isa}-devel = %{version}-%{release} > > > > Provides: prelude-devel = %{version}-%{release} > > > That's a bit unusual. Automatically generated provides are usually enough. > > > Why is this needed? > > > > There is a mistake, it should be preludedb-devel. This was an habit, as I do > > in libprelude. But this is just for the lib. Do I have to remove it ? > > Oh, I didn't even see that it's "prelude" not "preludedb". > But even with that correction, it still doesn't make sense: > rpm will automatically generate the following: > Provides: prelude-devel = %{version}-%{release} > Provides: prelude-devel%{?_isa} = %{version}-%{release} > > and the spec file has: > Provides: %{name}%{?_isa}-devel = %{version}-%{release} > Provides: preludedb-devel = %{version}-%{release} > > The second of those is redundant, and the first is strange because > it has %{_isa} in the wrong place. You don't _have_ to remove it, > but since it doesn't seem to serve any purpose, you _should_. > It seem to be some legacy craft, and since you're unretiring the > package, you can start with a clean slate. You are right, I did it > > > > - Package does not contain duplicates in %files. > > > Note: warning: File listed twice: > > > /usr/share/libpreludedb/classic/mysql2pgsql.sh > > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > > > > I do not have this on my side, can you help me on this ? > > %files devel > %{_datadir}/%{name} > ... > %attr(0755,-,-) %{_datadir}/%{name}/classic/mysql2pgsql.sh > > So that file is listed twice, in the sense that it's included recursively > in the directory, and later separately. > > The best option imho would be to just drop mysql2pgsql.sh, mysql2sqlite.sh > from the %files section completely. Looking into the tarball, they seem > to have proper permissions already. There is an issues with permissions. That was why I put it in this way the first time. I move the chmod into the install so the %files can be as it must be. Note: I will update the libprelude package with each part of the actual review that we forgot in the libprelude review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx