https://bugzilla.redhat.com/show_bug.cgi?id=1398949 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugs.michael@xxxxxxx --- Comment #34 from Michael Schwendt <bugs.michael@xxxxxxx> --- There are two things that seem to have slipped through during package review. At least they have not been commented on: > %build > %cmake -DBEAR_ENGINE_INSTALL_LIBRARY_DIR=%{_lib}/%{name} \ > -DBEAR_FACTORY_INSTALL_LIBRARY_DIR=%{_lib}/%{name} \ What's the goal of relocating the libs into that directory? Where would they be installed by default? Where do dependencies search for the bear libs by default? Do they CMake files as included within the Fedora bear packages find the libs by default? > %config(noreplace) %{_sysconfdir}/ld.so.conf.d/%{name}-engine-%{_arch}.conf This ld.so config file adds the same directory to runtime linker's search path. Of course! Else they wouldn't be found in that path. But that makes them available globally again, just as if they were put into %_libdir directly. And the ld.so cache contents even are searched before the system's libdirs. So, there is no gain from relocating them. Not running "ldconfig" in the scriptlets of the -engine and -factory subpackages is a related mistake, because of the added ld.so config files that extend the search path. Anything else (a package or the admin) that runs ldconfig, would also find the bear libs and add them to the cache. And then uninstalling the package, the cache ought to be updated again to remove the lib entries again. $ ldconfig -p|grep bear libbear_visual.so (libc6,x86-64) => /usr/lib64/bear/libbear_visual.so libbear_universe.so (libc6,x86-64) => /usr/lib64/bear/libbear_universe.so libbear_time.so (libc6,x86-64) => /usr/lib64/bear/libbear_time.so libbear_text_interface.so (libc6,x86-64) => /usr/lib64/bear/libbear_text_interface.so libbear_net.so (libc6,x86-64) => /usr/lib64/bear/libbear_net.so libbear_input.so (libc6,x86-64) => /usr/lib64/bear/libbear_input.so libbear_gui.so (libc6,x86-64) => /usr/lib64/bear/libbear_gui.so libbear_generic_items.so (libc6,x86-64) => /usr/lib64/bear/libbear_generic_items.so libbear_expr.so (libc6,x86-64) => /usr/lib64/bear/libbear_expr.so libbear_engine.so (libc6,x86-64) => /usr/lib64/bear/libbear_engine.so libbear_debug.so (libc6,x86-64) => /usr/lib64/bear/libbear_debug.so libbear_communication.so (libc6,x86-64) => /usr/lib64/bear/libbear_communication.so libbear_audio.so (libc6,x86-64) => /usr/lib64/bear/libbear_audio.so > %{_mandir}/man6/running-%n{ame}.6* This refers to a missing executable. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx