https://bugzilla.redhat.com/show_bug.cgi?id=1411354 --- Comment #4 from Neal Gompa <ngompa13@xxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated". 60 files have unknown license. Detailed output of licensecheck in /home/makerpm/1411354-gplugin/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/girepository-1.0 (gobject-introspection, libxklavier, GConf2, libgnome-keyring, gdk- pixbuf2, vte3, gtk2, atk, gcr, vte291, appstream, gucharmap-libs, gtk3), /usr/share/gir-1.0(fcitx-devel, libgee06-devel, gtk2-devel, appstream-devel, gspell-devel, vte291-devel, libgdata-devel, libchamplain-devel, gobject-introspection-devel, maliit-framework- devel, libgee-devel, libxklavier-devel, vte-devel, gcr-devel, gst- transcoder-devel, megatools, libzapojit-devel, gnome-bluetooth-libs- devel, libgtop2-devel, libgdl-devel, libgnome-keyring-devel, gst- transcoder, colord-gtk-devel, gocl-devel, atk-devel, gdk- pixbuf2-devel, gucharmap-devel, vte3-devel, libmash-devel, vips-devel, GConf2-devel, grilo-devel, gnome-online-accounts-devel, gtk3-devel, gsound-devel, gnome-autoar-devel, libgepub-devel, totem-pl-parser- devel, gstreamer1-rtsp-server-devel, gfbgraph-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gplugin- libs , gplugin-gtk , gplugin-gtk-libs , gplugin-loader-python , gplugin-loader-lua , gplugin-devel , gplugin-gtk-devel , gplugin- debuginfo [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gplugin-0.27.0-2.fc26.x86_64.rpm gplugin-libs-0.27.0-2.fc26.x86_64.rpm gplugin-gtk-0.27.0-2.fc26.x86_64.rpm gplugin-gtk-libs-0.27.0-2.fc26.x86_64.rpm gplugin-loader-python-0.27.0-2.fc26.x86_64.rpm gplugin-loader-lua-0.27.0-2.fc26.x86_64.rpm gplugin-devel-0.27.0-2.fc26.x86_64.rpm gplugin-gtk-devel-0.27.0-2.fc26.x86_64.rpm gplugin-debuginfo-0.27.0-2.fc26.x86_64.rpm gplugin-0.27.0-2.fc26.src.rpm gplugin.x86_64: W: spelling-error Summary(en_US) GObject -> G Object, Object gplugin-gtk-libs.x86_64: W: no-documentation gplugin-loader-python.x86_64: W: no-documentation gplugin-loader-lua.x86_64: W: no-documentation gplugin-devel.x86_64: W: spelling-error Summary(en_US) libs -> lobs, lib, lbs gplugin-devel.x86_64: W: spelling-error %description -l en_US libs -> lobs, lib, lbs gplugin-devel.x86_64: W: only-non-binary-in-usr-lib gplugin-devel.x86_64: W: no-documentation gplugin-gtk-devel.x86_64: W: spelling-error Summary(en_US) libs -> lobs, lib, lbs gplugin-gtk-devel.x86_64: W: spelling-error %description -l en_US libs -> lobs, lib, lbs gplugin-gtk-devel.x86_64: W: only-non-binary-in-usr-lib gplugin-gtk-devel.x86_64: W: no-documentation gplugin.src: W: spelling-error Summary(en_US) GObject -> G Object, Object 10 packages and 0 specfiles checked; 0 errors, 13 warnings. Rpmlint (debuginfo) ------------------- Checking: gplugin-debuginfo-0.27.0-2.fc26.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory gplugin-loader-python.x86_64: W: no-documentation gplugin-loader-lua.x86_64: W: no-documentation gplugin-gtk-devel.x86_64: W: spelling-error Summary(en_US) libs -> lobs, lib, lbs gplugin-gtk-devel.x86_64: W: spelling-error %description -l en_US libs -> lobs, lib, lbs gplugin-gtk-devel.x86_64: W: only-non-binary-in-usr-lib gplugin-gtk-devel.x86_64: W: no-documentation gplugin-gtk-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgplugin-gtk.so.0.1.0 /lib64/libgdk-3.so.0 gplugin-gtk-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgplugin-gtk.so.0.1.0 /lib64/libpangocairo-1.0.so.0 gplugin-gtk-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgplugin-gtk.so.0.1.0 /lib64/libpango-1.0.so.0 gplugin-gtk-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgplugin-gtk.so.0.1.0 /lib64/libatk-1.0.so.0 gplugin-gtk-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgplugin-gtk.so.0.1.0 /lib64/libcairo-gobject.so.2 gplugin-gtk-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgplugin-gtk.so.0.1.0 /lib64/libcairo.so.2 gplugin-gtk-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgplugin-gtk.so.0.1.0 /lib64/libgdk_pixbuf-2.0.so.0 gplugin-gtk-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgplugin-gtk.so.0.1.0 /lib64/libgio-2.0.so.0 gplugin-gtk-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libgplugin-gtk.so.0.1.0 /lib64/libgmodule-2.0.so.0 gplugin-gtk-libs.x86_64: W: no-documentation gplugin.x86_64: W: spelling-error Summary(en_US) GObject -> G Object, Object gplugin-devel.x86_64: W: spelling-error Summary(en_US) libs -> lobs, lib, lbs gplugin-devel.x86_64: W: spelling-error %description -l en_US libs -> lobs, lib, lbs gplugin-devel.x86_64: W: only-non-binary-in-usr-lib gplugin-devel.x86_64: W: no-documentation 9 packages and 0 specfiles checked; 0 errors, 21 warnings. Requires -------- gplugin-loader-python (rpmlib, GLIBC filtered): gplugin-libs(x86-64) libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgplugin.so.0()(64bit) libpython3.6m.so.1.0()(64bit) rtld(GNU_HASH) gplugin-loader-lua (rpmlib, GLIBC filtered): gplugin-libs(x86-64) libc.so.6()(64bit) libdl.so.2()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgplugin.so.0()(64bit) liblua-5.3.so()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) gplugin-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgplugin.so.0()(64bit) rtld(GNU_HASH) gplugin-gtk-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gplugin-gtk-libs(x86-64) libgplugin-gtk.so.0()(64bit) pkgconfig(glib-2.0) pkgconfig(gmodule-2.0) pkgconfig(gobject-2.0) pkgconfig(gplugin) gplugin-gtk-libs (rpmlib, GLIBC filtered): /sbin/ldconfig gplugin-libs(x86-64) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgplugin.so.0()(64bit) libgtk-3.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) rtld(GNU_HASH) gplugin-debuginfo (rpmlib, GLIBC filtered): gplugin-gtk (rpmlib, GLIBC filtered): gplugin-gtk-libs(x86-64) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgplugin-gtk.so.0()(64bit) libgplugin.so.0()(64bit) libgtk-3.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) rtld(GNU_HASH) gplugin (rpmlib, GLIBC filtered): gplugin-libs(x86-64) libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgplugin.so.0()(64bit) rtld(GNU_HASH) gplugin-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config gplugin-libs(x86-64) libgplugin.so.0()(64bit) pkgconfig(glib-2.0) pkgconfig(gmodule-2.0) pkgconfig(gobject-2.0) Provides -------- gplugin-loader-python: gplugin-loader-python gplugin-loader-python(x86-64) gplugin-loader-lua: gplugin-loader-lua gplugin-loader-lua(x86-64) gplugin-libs: gplugin-libs gplugin-libs(x86-64) libgplugin.so.0()(64bit) gplugin-gtk-devel: gplugin-gtk-devel gplugin-gtk-devel(x86-64) pkgconfig(gplugin-gtk) gplugin-gtk-libs: gplugin-gtk-libs gplugin-gtk-libs(x86-64) libgplugin-gtk.so.0()(64bit) gplugin-debuginfo: gplugin-debuginfo gplugin-debuginfo(x86-64) gplugin-gtk: gplugin-gtk gplugin-gtk(x86-64) gplugin: gplugin gplugin(x86-64) gplugin-devel: gplugin-devel gplugin-devel(x86-64) pkgconfig(gplugin) Unversioned so-files -------------------- gplugin-libs: /usr/lib64/gplugin/gplugin-license-check.so gplugin-loader-python: /usr/lib64/gplugin/gplugin-python.so gplugin-loader-lua: /usr/lib64/gplugin/gplugin-lua.so Source checksums ---------------- https://bitbucket.org/gplugin/main/downloads/gplugin-0.27.0.tar.bz2 : CHECKSUM(SHA256) this package : e9ea776497978097bd1ffcfa49521b8cddb333a37a46c3c14220337d2a32f081 CHECKSUM(SHA256) upstream package : e9ea776497978097bd1ffcfa49521b8cddb333a37a46c3c14220337d2a32f081 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/bin/fedora-review -b 1411354 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx