https://bugzilla.redhat.com/show_bug.cgi?id=1410007 --- Comment #3 from Peter Robinson <pbrobinson@xxxxxxxxx> --- > Issues: > ======= > - License seems to disagree with output of licensecheck See below > - Packages do not install properly (mraa-devel has a dependency on > /bin/usr/env, > which seems obviously wrong) It seems to come from some of the examples (see rpmlint output) so I'm not sure it is wrong. Suggestions? > - License file isn't installed w/ certain subpackages Not sure which ones, all sub packages have a dependency on "Requires: %{name}%{?_isa} = %{version}-%{release}" which will bring in the license file. > - Package doesn't own all of the directories it creates > - Sub-packages should have fully-versioned dependency They all depend on "Requires: %{name}%{?_isa} = %{version}-%{release}" which I believe to be correct. Can you be more specific. > - Many js and python scripts without proper shebang I'll report that upstream. > [!]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Apache (v2.0)", "*No copyright* BSL", "Unknown or generated", > "*No copyright* LGPL (v2.1)", "MIT/X11 (BSD like)", "BSL (v1.0)", "*No > copyright* BSD (3 clause)", "BSD (3 clause)". 104 files have unknown > license. Detailed output of licensecheck in > /home/jsmith/Documents/Personal/Reviews/1410007-mraa/licensecheck.txt The COPYING file states it's MIT so I've updates it to that. > [!]: License file installed when any subpackage combination is installed. See note above. > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/libexec/mraa Fixed. > [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/lib64/python3.6/site- > packages/__pycache__(system-python-libs, audit-libs-python3) I don't see the issue there > [!]: Final provides and requires are sane (see attachments). > [!]: Fully versioned dependency in subpackages if applicable. > Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mraa- > debuginfo debuginfo is a automatically generated package. I don't see this is a packaging problem. SPEC: as above SRPM: https://pbrobinson.fedorapeople.org/mraa-1.5.1-2.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx