Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alliance - Alliance VLSI CAD Sytem https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=248649 ------- Additional Comments From kwizart@xxxxxxxxx 2007-07-17 21:53 EST ------- Ok so few comments to start: 1 / prefix seems problematic. But since no arch dependant files are installed in it, this could be fine if we can have configs files in /etc actually... Also no %config(no replace) seems to be used for users config files... 2 / evr problem The source has 20060509 but this do not appear in evr wheras this should appear inside the release tag (if release, then >= 1). Others sources have the same version (in OLD_RELEASES ). So this will need to add 20060509snap in the release field to make a difference. 3 / URL has changed to http://www-asim.lip6.fr/recherche/alliance/ 4 / patches macros. - As the pacakge name is good why do you need to uses %{name}? this bring some confusion when looking for the patch instead of having the full name. - Some patches are backport from older version (+ is older than -) This mean that some patches could be usefull with later release ? I cannot see the aim of using %{version} in this case! Unless it will break patch historicy in cvs if no changes are made to the patch for later releases. 5 / desktop files * You missed Requires(post): desktop-file-utils Requires(postun): desktop-file-utils * I don't know if the shortcuts will be in the right category... * see scriplets - 11 / 6 / About the kindly requested https://www.redhat.com/archives/fedora-devel-list/2007-July/msg00750.html Why do you choose not to show the "kindly requested" in %description ? 7 / %configure * This package do not conform to the standard paths and use a prefix with --with-alliance-top=%{prefix}. But, do you need to export it to make it work ? * --disable-static is avaible why don't you uses it ? Does it works ? 8 / # applying timestamps What do you mean by this ? This could go in %prep for Source7 9 / # documentation Why do you copy them it "." ? (you do not seems to use them after that...) It could be safer to copy all of them in a created __doc - This will need to be remove just before %install like: %{__rm} -rf %{buildroot} __doc 10 / #conflicts with man-pages and is a duplicate of log.1.gz This make rise the problem of too much generic names appear (Which I haven't checked yet). Maybe a renamed could be enought if the --program-prefix do not work if this apply. 11 / scriplets * %preun -p /sbin/ldconfig - This is unneeded * Recommand to have this if desktop file has a MimeType key. %post /sbin/ldconfig update-desktop-database &> /dev/null || : %postun /sbin/ldconfig update-desktop-database &> /dev/null || : 12 / # duplicate and unstripped-binary-or-object %exclude %{_libdir}/debug * This is wrong on x86_64 and also uneeded (tested) 13 / %{_includedir}/* * header are presents in main but not in devel - Is it possible to sort those that should be used at runtime from those that are needed for developping alliance ? 14 / %{_mandir}/man?/* * Check if some of them shouldn't go in -devel 15 / #Makefiles are present in alliance-examples/* * Is it possible to have another sub-package for these examples (which will follow others rules of Requirement eventually ) * Having users to build them is %doc directory is not fair - Thoses can go in %{_datadir}/alliance/examples. 16 / build fails on x86_64 FC6: (i will give a retry ) /usr/bin/ld: cannot find -lMvg collect2: ld returned 1 exit status make[2]: *** [x2vy] Error 1 make[2]: *** Waiting for unfinished jobs.... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review