https://bugzilla.redhat.com/show_bug.cgi?id=1320878 --- Comment #5 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- Manual checks: ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. OK. [ ]: Package contains no static executables. OK. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. OK. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 160 files have unknown license. Detailed output of licensecheck in /home/vitaly/1320878-libjson-rpc-cpp/licensecheck.txt OK. [ ]: License file installed when any subpackage combination is installed. OK. [ ]: %build honors applicable compiler flags or justifies otherwise. OK. [ ]: Package contains no bundled libraries without FPC exception. OK. [ ]: Changelog in prescribed format. OK. [ ]: Sources contain only permissible code or content. OK. [ ]: Package contains desktop file if it is a GUI application. OK. [ ]: Development files must be in a -devel package OK. [ ]: Package uses nothing in %doc for runtime. OK. [ ]: Package consistently uses macros (instead of hard-coded directory names). OK. [ ]: Package is named according to the Package Naming Guidelines. OK. [ ]: Package does not generate any conflict. OK. [ ]: Package obeys FHS, except libexecdir and /usr/target. OK. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. OK. [ ]: Requires correct, justified where necessary. OK. [ ]: Spec file is legible and written in American English. OK. [ ]: Package contains systemd file(s) if in need. OK. [ ]: Useful -debuginfo package or justification otherwise. OK. [ ]: Package is not known to require an ExcludeArch tag. OK. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. OK. [ ]: Package complies to the Packaging Guidelines OK. ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. OK. [ ]: Final provides and requires are sane (see attachments). OK. [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libjson- rpc-cpp-devel , libjson-rpc-cpp-common , libjson-rpc-cpp-client , libjson-rpc-cpp-server , libjson-rpc-cpp-stub , libjson-rpc-cpp-tools , libjson-rpc-cpp-debuginfo Requires -common. OK. [ ]: Package functions as described. OK. [ ]: Latest version is packaged. OK. [ ]: Package does not include license text files separate from upstream. OK. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. OK. [ ]: Scriptlets must be sane, if used. OK. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. Not required. [ ]: Package should compile and build into binary rpms on all supported architectures. OK. [ ]: %check is present and all tests pass. OK. Pass. [ ]: Packages should try to preserve timestamps of original installed files. OK. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx