https://bugzilla.redhat.com/show_bug.cgi?id=1328248 Filip Szymański <fszymanski@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fszymanski@xxxxxxx --- Comment #4 from Filip Szymański <fszymanski@xxxxxxx> --- 1) Rename the spec file to python-pysword.spec 2) You only need these two globals: %global srcname pysword %global commit 50a1b1a526e5d6511555c458df754498aaa3185f 3) Tags: Version: 0.2.3 Source0: https://gitlab.com/tgc-dk/%{srcname}/repository/archive.tar.gz?ref=%{version}#/%{srcname}-%{version}.tar.gz 4) Description expands upon summary. 5) Instead of `sum` macro use `summary`: %package -n python3-%{srcname} Summary: %{summary} %{?python_provide:%python_provide python3-%{srcname}} 6) Prepare section: %prep %autosetup -n %{srcname}-%{version}-%{commit} 7) Missing doc and license file: %files -n python3-%{srcname} %license LICENSE %doc README.rst %{python3_sitelib}/* 8) Email address should be in `<>`. See: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx