https://bugzilla.redhat.com/show_bug.cgi?id=1403314 Stephen Gallagher <sgallagh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(sgallagh@redhat.c | |om) | --- Comment #5 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- (In reply to Merlin Mathesius from comment #3) > Thank you for addressing my questions and concerns. > > I verified the updated package functions as described. > > I now have a few additional questions/concerns: > > * Is the intent that > /usr/lib/python*/site-packages/publicsuffix/public_suffix_list.dat be a > symlink to /usr/share/publicsuffix/public_suffix_list.dat, or a regular file > copy of public_suffix_list.dat picked up from the publicsuffix-list package > at RPM build time? It was a link in the previous version of this package, > now it's a regular file. > It was supposed to be a link. I guess moving that change into the %prep phase was the wrong approach. I will correct it. > * The %changelog version-revision tag is now 1.1.0-1, but based on the > Version and Release, it should be 1.1.0-0.7. I presume this is anticipation > of bumping the Release to 1 upon actual release? > Yes, that's purely cosmetic. > * I just noticed the warning that rpmlint doesn't like the Summary: to end > with a period. It's just a warning. I'm choosing to ignore that completely. > One more thing: > > * If the intent is to still have a Requires for publicsuffix-list, it needs > to be specified in the subpackages--not the main package. Whoops! You are exactly right. Spec: https://sgallagh.fedorapeople.org/packagereview/python-publicsuffix/python-publicsuffix.spec SRPM: https://sgallagh.fedorapeople.org/packagereview/python-publicsuffix/python-publicsuffix-1.1.0-0.8.fc25.src.rpm COPR: https://copr.fedorainfracloud.org/coprs/sgallagh/python-publicsuffix/build/496019/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx