[Bug 1406797] Review Request: python-ansicolor - A library to produce ansi color output, colored highlighting and diffing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1406797



--- Comment #2 from Filip Szymański <fszymanski@xxxxxxx> ---
Spec URL:
https://fszymanski.fedorapeople.org/python-ansicolor/python-ansicolor.spec
SRPM URL:
https://fszymanski.fedorapeople.org/python-ansicolor/python-ansicolor-0.2.4-2.fc25.src.rpm

Hi Iryna,
Thank you for taking the time to review this package.

You are absolutely right that I have to add the license file to the -doc
subpackage, and that the `sum` macro is unnecessary.

When it comes to the wildcards Python packaging guidelines suggest to use them
to capture both the module directory and the egg-info directory.

See:
https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Egg_Metadata_Using_Setuptools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]