https://bugzilla.redhat.com/show_bug.cgi?id=1368855 --- Comment #4 from Lubomir Rintel <lkundrak@xxxxx> --- Looks generally good. A few comments inline. Note that the style comments are in generally merely my opinions, not blockers. > Name: radare2 > Version: 0.10.5 Please update to the 1.1.0 release tarball. > Release: 1%{?dist} > Summary: The %{name} reverse engineering framework This looks terrible. Please consider *not* using macro expansion for every single occurrence of a substring. > Group: Applications/Engineering Probably not the right category. Development/Tools is more suitable (or Development/Debuggers). > License: LGPLv3 Some parts of the package use a different license; e.g. shlr/grub is apparently GPLv3+, shlr/qnx is probably GPL+, shlr/zip looks like BSD, etc. > URL: http://radare.org/ > #URL: https://github.com/radare/radare2 Drop a useless comment please. > Source0: https://github.com/%{gituser}/%{gitname}/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz > Source1: https://github.com/%{gituser}/%{sdbgitname}/archive/%{sdbcommit}/%{sdbgitname}-%{version}-%{sdbshort}.tar.gz This source is not used at all. > %description > The %{name} is a reverse-engineering framework that is multi-architecture, > multi-platform, and highly scriptable. %{name} provides a hexadecimal > editor, wrapped I/O, file system support, debugger support, diffing > between two functions or binaries, and code analysis at opcode, > basic block, and function levels. Another couple of useless macro expansions. Please get rid of them. > %build > %configure --with-sysmagic --with-syszip --with-syscapstone You don't enable openssl. Why? (no idea what is it used for) > CFLAGS="%{optflags} -fPIC -I../include" make %{?_smp_mflags} LIBDIR=%{_libdir} PREFIX=%{_prefix} DATADIR=%{DATADIR} %{DATADIR}? > %install > rm -rf %{buildroot} Cleaning buildroot is not needed anymore. > NOSUDO=1 make install DESTDIR=%{buildroot} LIBDIR=%{_libdir} PREFIX=%{_prefix} > cp shlr/sdb/src/libsdb.a %{buildroot}/%{_libdir}/libsdb.a No static libraries please; drop this one. > %files > %doc AUTHORS.md CONTRIBUTING.md DEVELOPERS.md README.md TODO.md doc/* > %doc %{_datadir}/doc/%{name} Drop this one; it's no longer needed or allowed. > %post -n %{name}-devel -p /sbin/ldconfig > %postun -n %{name}-devel -p /sbin/ldconfig Why? You're not supposed to ship libraries in -devel packages; and you most likely are not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx