https://bugzilla.redhat.com/show_bug.cgi?id=1409866 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- Next time, please link to raw spec file. Not an HTML document. URL and Source addresses are usable. Ok. Source archive is original (SHA-256: 29b190112117c50ef08d02caedb3c325af48fad3e5a8d195a38cec0470e235d0). Ok. FIX: Do not undefine the %debug_package macro. debuginfo packages are not created for noarch packages by default. FIX: The summary text is poor. Instead of naming modules the package contains it should summaries purpose of the package. For example `Sun rise and set times'. Description verified from README. Ok. TODO: I think the `perl' in the description text should be spelled as `Perl' because it's a name of a programming language. `perl' denotes the Perl interpreter, a command for executing /usr/bin/perl. FIX: There is no license text or disclaimer in the sources. Where did you find that `GPL+ or Artistic' applies? In case there is no license defined in the sources, one has to contact author of the sources and ask him/her for clarification. If the author does not release a new version that will include the license, the author's clarification (e.g. an e-mail response with all e-mail headers) must be added to the package using %license macro in the %files section. If author does not provide any clarification acceptable by Fedora legal team, the package cannot be distributed withing Fedora distribution because copyright law denies redistributing copyrighted material by default. The missing license is a fatal problem and I would stop the review now until resolving it. But because you are newbie, I will continue and show you what other deficiencies should be fixed in this package. No XS code, noarch BuildArch is Ok. TODO: You can simplify the find command in the %install section like this: find %{buildroot} -type f -name .packlist -delete Otherwise you should build-require `coreutils' because you execute `rm' command provided by coreutils package. TODO: Do not package `MANIFEST' file. It has no meaning in RPM package, it's used only by CPAN site. TODO: Do not package `test.pl' file. We normally do not package tests as they are not needed at run time. We package them as a documentation if there is not any better documentation. This package does not have any documentation, but the test.pl actually does not show any usage of Astro::SunTime API, so it'd not good as as a documentation as well. FIX: Build-require `perl' because you execute perl in perl-Astro-SunTime.spec at lines 17 and 26. FIX: Build-require `findutils' (perl-Astro-SunTime.spec:32). FIX: Build-require `coreutils' (perl-Astro-SunTime.spec:32). FIX: Build-require these Perl modules because they are used when executing tests: `perl(POSIX)' (SunTime.pm:10) `perl(strict)' (SunTime.pm:12) `perl(Time::ParseDate)' (SunTime.pm:9) `perl(vars)' (SunTime.pm:2). You can use `tangerine' tool the scan the sources for used Perl modules. You can verify the modules are used by mangling their identifiers to non-existing modules in the sources and than executing `make test'. All tests pass. Ok. $ rpmlint perl-Astro-SunTime.spec ../SRPMS/perl-Astro-SunTime-0.01-4.fc26.src.rpm ../RPMS/noarch/perl-Astro-SunTime-0.01-4.fc26.noarch.rpm perl-Astro-SunTime.spec:8: W: non-standard-group Applications/CPAN perl-Astro-SunTime.spec:48: W: macro-in-%changelog %check perl-Astro-SunTime.src: E: description-line-too-long C Astro::SunTime perl module provides a function interface to calculate sun rise/set times. perl-Astro-SunTime.src: W: non-standard-group Applications/CPAN perl-Astro-SunTime.src:48: W: macro-in-%changelog %check perl-Astro-SunTime.noarch: E: description-line-too-long C Astro::SunTime perl module provides a function interface to calculate sun rise/set times. perl-Astro-SunTime.noarch: W: non-standard-group Applications/CPAN perl-Astro-SunTime.noarch: W: incoherent-version-in-changelog 0.03-4 ['0.01-4.fc26', '0.01-4'] perl-Astro-SunTime.noarch: W: manifest-in-perl-module /usr/share/doc/perl-Astro-SunTime/MANIFEST 2 packages and 1 specfiles checked; 2 errors, 7 warnings. FIX: Change the Group tag value to one enumerated in /usr/share/doc/rpm/GROUPS (`Development/Libraries' probably) or remove the tag because it's deprecated in Fedora. FIX: Escape `%' character in the %changelog by another per-cent character. FIX: Correct version number for the latest %changelog entry to match Version tag. $ rpm -q -lv -p ../RPMS/noarch/perl-Astro-SunTime-0.01-4.fc26.noarch.rpm drwxr-xr-x 2 root root 0 Jan 4 13:55 /usr/share/doc/perl-Astro-SunTime -rw-r--r-- 1 root root 105 Nov 8 1999 /usr/share/doc/perl-Astro-SunTime/Changes -rw-r--r-- 1 root root 55 Dec 13 1999 /usr/share/doc/perl-Astro-SunTime/MANIFEST -rw-r--r-- 1 root root 80 Dec 13 1999 /usr/share/doc/perl-Astro-SunTime/README -rw-r--r-- 1 root root 659 Nov 8 1999 /usr/share/doc/perl-Astro-SunTime/test.pl drwxr-xr-x 2 root root 0 Jan 4 13:55 /usr/share/perl5/vendor_perl/Astro -r--r--r-- 1 root root 2920 Nov 8 1999 /usr/share/perl5/vendor_perl/Astro/SunTime.pm File layout and permissions is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Astro-SunTime-0.01-4.fc26.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(POSIX) 1 perl(strict) 1 perl(Time::ParseDate) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Astro-SunTime-0.01-4.fc26.noarch.rpm | sort -f | uniq -c 1 perl(Astro::SunTime) = 0.01 1 perl-Astro-SunTime = 0.01-4.fc26 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Astro-SunTime-0.01-4.fc26.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F26 (https://koji.fedoraproject.org/koji/taskinfo?taskID=17161871). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items and provide updated spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx