https://bugzilla.redhat.com/show_bug.cgi?id=1330343 R. Francis Smith <rfrancis@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rfrancis@xxxxxxxxxxxxxx --- Comment #6 from R. Francis Smith <rfrancis@xxxxxxxxxxxxxx> --- [Disclaimer: very very new to this. But I have a thought that seemed worth sharing, and is relevant.] Having run across this, I dig some digging in both sources and have an observation and a perhaps naive question: why is contrib/iprange in the haproxy dist being installed in _bindir anyway? It's excessively special purpose (and a little cantankerous -- the input file has to have at least one extra character after the two IPs or it ignores the line, which yes, is fixable, but that's not my point) and, in fact, the iprange package in question here can do the same thing with a little work: Input file (input.txt): # two spaces because contrib/iprange from haproxy eats the first space as per my parenthetical above 139.78.140.0,139.78.143.255 # this is a range >From haproxy/contrib/iprange: $ ./iprange < input.txt 139.78.140.0/22 this is a range >From iprange per github:firehol/iprange: $ paste <(cut -d" " -f1 input.txt | sed "s/,/-/" | ./iprange -) <(cut -d" " -f2- input.txt) 139.78.140.0/22 # this is a range Okay, a little kludgy, but on the other hand, the one from haproxy's contrib eats characters anyway, so... My point is that I don't really understand why contrib/iprange from haproxy needs to be installed in _bindir instead of making the contrib source available under /usr/share/doc -- in point of fact, the current package appears to be throwing away everything under contrib but halog and iprange -- and then the problem here goes away. :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx