[Bug 1409780] Review Request: golang-github-hanwen-go-fuse - FUSE bindings for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1409780



--- Comment #5 from Ralf Senderek <fedora@xxxxxxxxxxx> ---
Just a few comments to help you write a more comprehensible spec file:

You have to make yourself familiar with the packaging guidelines:

   https://fedoraproject.org/wiki/Packaging:Guidelines

and the packaging naming guidelines:

  
https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines

I'd recommend to go through you package's spec file and also through the list
of files your package would contain, and ask yourself if everything complies
with these two documents.

Then I'd think that you'd get rid of all unnecessary global variables and 
most of the conditional statements in your spec file. Please start to write
comments above a conditional that clearly states why you need it, and if
you cannot come up with a convincing reason get rid of it. Some - if not most
things - will be done unconditionally in a spec file.

Try to find out what level of complexity is necessary for your packaging
project
and start building sub-packages only if there is a reason for it. It's easier
to
convince a sponsor to help you get your package approved if you can show that
you understand why you introduced a complexity into your spec file instead of
starting from an unnecessary complex template that does not fit your project.

Keep updating your spec file and I wish you the best of luck to find a sponsor.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]