https://bugzilla.redhat.com/show_bug.cgi?id=1409780 --- Comment #3 from Michael Schwendt <bugs.michael@xxxxxxx> --- fedora-review is not bullet-proof, and human reviewers aren't either. ;) There seems to be an ongoing effort to get some "Go Packaging Guidelines" through the FPC for several years: https://fedorahosted.org/fpc/ticket/382 Skimming over the draft, it seems its makers like the macro overload, and it could be that some of the existing packages apply the same packaging style already. Well, the maintenance burden is on the shoulders of those, who maintain such golang packages. It could be that other golang packagers love this packaging style. About the conditional builds, many packagers would prefer %bcond_with/_without over %global constants. It is too much of a risk to switch a global temporarily and not reset it again before committing changes to dist git. You can toggle %bcond_ settings from the outside for test-builds (passing --with/--without foo options to rpmbuild) with no need to modify the spec file. > $ rpmlint -i golang-github-hanwen-go-fuse-* > golang-github-hanwen-go-fuse-unit-test.x86_64: E: devel-dependency > golang-github-hanwen-go-fuse-devel > Your package has a dependency on a devel package but it's not > a devel package itself. Any reason why this -test package is not noarch, too? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx